From: Chong Yidong <cyd@stupidchicken.com>
To: Alan Mackenzie <acm@muc.de>
Cc: Daniel Colascione <dan.colascione@gmail.com>, 7580@debbugs.gnu.org
Subject: bug#7580: [PATCH] cc-mode bitfield fontification bug
Date: Fri, 21 Jan 2011 22:06:26 -0500 [thread overview]
Message-ID: <87fwslbpsd.fsf__19880.7907560424$1295666745$gmane$org@stupidchicken.com> (raw)
In-Reply-To: <4CFE29EE.4000200@gmail.com> (Daniel Colascione's message of "Tue, 07 Dec 2010 04:34:54 -0800")
Hi Alan,
Could you please review this patch? Thanks!
Daniel Colascione <dan.colascione@gmail.com> writes:
> struct test
> {
> /* Both should be fontified as bitfields; currently, only the former
> is */
> int bf1:5;
> unsigned bf2:5;
> };
>
>
> @@ -5575,7 +5656,9 @@
> ;; a valid label. Otherwise the last one probably is the
> ;; declared identifier and we should back up to the previous
> ;; type, providing it isn't a cast.
> - (if (eq (char-after) ?:)
> + (if (and (eq (char-after) ?:)
> + (not (and (eq backup-at-type 'prefix)
> + (eq at-type 'maybe))))
> ;; If we've found a specifier keyword then it's a
> ;; declaration regardless.
> (throw 'at-decl-or-cast (eq at-decl-or-cast t))
next prev parent reply other threads:[~2011-01-22 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 12:34 bug#7580: [PATCH] cc-mode bitfield fontification bug Daniel Colascione
2011-01-22 3:06 ` Chong Yidong [this message]
[not found] ` <87fwslbpsd.fsf@stupidchicken.com>
2011-10-03 20:35 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87fwslbpsd.fsf__19880.7907560424$1295666745$gmane$org@stupidchicken.com' \
--to=cyd@stupidchicken.com \
--cc=7580@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=dan.colascione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).