unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#10172: 24.0.92; compile-tests.el failure
@ 2011-11-30 18:09 Chong Yidong
  2011-11-30 19:26 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Chong Yidong @ 2011-11-30 18:09 UTC (permalink / raw)
  To: 10172

With latest trunk, `make check' fails with:

1 unexpected results:
   FAILED  compile-test-error-regexps

From further debugging, the columns reported by compilation-parse-errors
are now off by one.  Did the latest changes to compile.el switch the
column numbers from being 0-indexed to 1-indexed?

In GNU Emacs 24.0.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.2.0)
 of 2011-12-01 on furball
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
configured using `configure  '--with-x-toolkit=gtk3' 'CFLAGS=-g''





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#10172: 24.0.92; compile-tests.el failure
  2011-11-30 18:09 bug#10172: 24.0.92; compile-tests.el failure Chong Yidong
@ 2011-11-30 19:26 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2011-11-30 19:26 UTC (permalink / raw)
  To: Chong Yidong; +Cc: 10172

> With latest trunk, `make check' fails with:
> 1 unexpected results:
>    FAILED  compile-test-error-regexps

>> From further debugging, the columns reported by compilation-parse-errors
> are now off by one.  Did the latest changes to compile.el switch the
> column numbers from being 0-indexed to 1-indexed?

Well, it moved the moment where compilation-first-column is used, so
that impacts the values stored in the `compilation-message' property
(which used to have compilation-first-column applied but is now "raw").


        Stefan





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-30 19:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-30 18:09 bug#10172: 24.0.92; compile-tests.el failure Chong Yidong
2011-11-30 19:26 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).