unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#10417: 24.0.92; Shell completion regression for shell-completion-execonly
@ 2012-01-01 15:08 Chong Yidong
  2012-01-03  6:31 ` Chong Yidong
  2021-08-23 15:28 ` Lars Ingebrigtsen
  0 siblings, 2 replies; 6+ messages in thread
From: Chong Yidong @ 2012-01-01 15:08 UTC (permalink / raw)
  To: 10417

Suppose I have a non-executable file named screen.el in the current
directory.  With latest trunk:

emacs -q
M-: (setq shell-completion-execonly nil) RET
M-x shell RET
./scr
TAB

Emacs says "No match" in the minibuffer.  With Emacs 23, the TAB
completes "./scr" to "./screen.el", which is the expected result for
shell-completion-execonly nil.


In GNU Emacs 24.0.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.2.0)
 of 2011-12-30 on furball
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
configured using `configure  '--with-x-toolkit=gtk3' 'CFLAGS=-g''





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10417: 24.0.92; Shell completion regression for shell-completion-execonly
  2012-01-01 15:08 bug#10417: 24.0.92; Shell completion regression for shell-completion-execonly Chong Yidong
@ 2012-01-03  6:31 ` Chong Yidong
  2021-08-23 15:28 ` Lars Ingebrigtsen
  1 sibling, 0 replies; 6+ messages in thread
From: Chong Yidong @ 2012-01-03  6:31 UTC (permalink / raw)
  To: 10417

Chong Yidong <cyd@gnu.org> writes:

> Suppose I have a non-executable file named screen.el in the current
> directory.  With latest trunk:
>
> emacs -q
> M-: (setq shell-completion-execonly nil) RET
> M-x shell RET
> ./scr
> TAB
>
> Emacs says "No match" in the minibuffer.  With Emacs 23, the TAB
> completes "./scr" to "./screen.el", which is the expected result for
> shell-completion-execonly nil.

I fixed this by putting pcomplete-completions-at-point last in
shell-dynamic-complete-functions (revno 106763).





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10417: 24.0.92; Shell completion regression for shell-completion-execonly
  2012-01-01 15:08 bug#10417: 24.0.92; Shell completion regression for shell-completion-execonly Chong Yidong
  2012-01-03  6:31 ` Chong Yidong
@ 2021-08-23 15:28 ` Lars Ingebrigtsen
  2021-08-23 16:32   ` Eli Zaretskii
  1 sibling, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-08-23 15:28 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 10417

Chong Yidong <cyd@gnu.org> writes:

> Suppose I have a non-executable file named screen.el in the current
> directory.  With latest trunk:
>
> emacs -q
> M-: (setq shell-completion-execonly nil) RET
> M-x shell RET
> ./scr
> TAB
>
> Emacs says "No match" in the minibuffer.  With Emacs 23, the TAB
> completes "./scr" to "./screen.el", which is the expected result for
> shell-completion-execonly nil.

This was a decade ago, and I'm unable to reproduce this in Emacs 25.1
(or the current trunk).

But this bug report was reopened (by Eli) as a response to bug#42383, so
... perhaps I'm testing this wrong?  Or has this been re-fixed since it
was reopened a year ago?  (There has been changes in
shell-command-completion-function the last year, but I'm not sure
whether that explains it.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10417: 24.0.92; Shell completion regression for shell-completion-execonly
  2021-08-23 15:28 ` Lars Ingebrigtsen
@ 2021-08-23 16:32   ` Eli Zaretskii
  2021-08-25  8:47     ` Michalis V.
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2021-08-23 16:32 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 10417

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 10417@debbugs.gnu.org
> Date: Mon, 23 Aug 2021 17:28:50 +0200
> 
> This was a decade ago, and I'm unable to reproduce this in Emacs 25.1
> (or the current trunk).

The original report was in Emacs 24, not 25.  I don't have a working
Emacs 24 on Unix to try this.  For the trunk, it could be that the
completion-style preferences changed the default behavior.  Note that
the original report specifies an order of completion functions.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10417: 24.0.92; Shell completion regression for shell-completion-execonly
  2021-08-23 16:32   ` Eli Zaretskii
@ 2021-08-25  8:47     ` Michalis V.
  2021-08-25 10:04       ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Michalis V. @ 2021-08-25  8:47 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Lars Ingebrigtsen, 10417

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Cc: 10417@debbugs.gnu.org
>> Date: Mon, 23 Aug 2021 17:28:50 +0200
>> 
>> This was a decade ago, and I'm unable to reproduce this in Emacs 25.1
>> (or the current trunk).
>
> The original report was in Emacs 24, not 25.  I don't have a working
> Emacs 24 on Unix to try this.  For the trunk, it could be that the
> completion-style preferences changed the default behavior.  Note that
> the original report specifies an order of completion functions.

hi,

FWIW i can reproduce this in linux with build 24.0.92.1 (head
651e947eb84b9201faa63ff6dc855a8c99ac8018). Not reproducible in 24.5,
27.1 or 28.0.50

Michalis





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10417: 24.0.92; Shell completion regression for shell-completion-execonly
  2021-08-25  8:47     ` Michalis V.
@ 2021-08-25 10:04       ` Lars Ingebrigtsen
  0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-08-25 10:04 UTC (permalink / raw)
  To: Michalis V.; +Cc: 10417

"Michalis V." <mvar.40k@gmail.com> writes:

> FWIW i can reproduce this in linux with build 24.0.92.1 (head
> 651e947eb84b9201faa63ff6dc855a8c99ac8018). Not reproducible in 24.5,
> 27.1 or 28.0.50

Thanks for checking.  I'm closing this bug report, then.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-25 10:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-01 15:08 bug#10417: 24.0.92; Shell completion regression for shell-completion-execonly Chong Yidong
2012-01-03  6:31 ` Chong Yidong
2021-08-23 15:28 ` Lars Ingebrigtsen
2021-08-23 16:32   ` Eli Zaretskii
2021-08-25  8:47     ` Michalis V.
2021-08-25 10:04       ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).