From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Tue, 28 Feb 2012 10:34:54 +0100 Message-ID: <87fwdvmhc1.fsf@gmail.com> References: <87mx9su32g.fsf@web.de> <87ipiuvsbw.fsf@gmx.de> <87k439gyu5.fsf@gmail.com> <87fwdwhizm.fsf@gmail.com> <87bookhfcn.fsf@gmail.com> <87aa44o7qo.fsf@gmail.com> <87ty2c490n.fsf@gmail.com> <87r4xgkt2b.fsf@gmail.com> <87obskum9i.fsf@gmx.de> <874nuc9bao.fsf@gmail.com> <874nubzdsu.fsf@gmail.com> <87zkc3xwdn.fsf@gmail.com> <87k437o1hm.fsf@gmx.de> <87vcmrxtk2.fsf@gmail.com> <87pqczxsu0.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330421793 16094 80.91.229.3 (28 Feb 2012 09:36:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 28 Feb 2012 09:36:33 +0000 (UTC) Cc: 10489@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 28 10:36:32 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S2JTz-0003vH-RN for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Feb 2012 10:36:32 +0100 Original-Received: from localhost ([::1]:37376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2JTz-0002MN-7C for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Feb 2012 04:36:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2JTw-0002MH-Kn for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 04:36:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2JTq-0004S2-BM for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 04:36:28 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2JTq-0004Ry-48 for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 04:36:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S2JWQ-0001rL-GV for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 04:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Feb 2012 09:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.13304219137102 (code B ref 10489); Tue, 28 Feb 2012 09:39:02 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 28 Feb 2012 09:38:33 +0000 Original-Received: from localhost ([127.0.0.1]:60760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2JVr-0001qC-Ex for submit@debbugs.gnu.org; Tue, 28 Feb 2012 04:38:33 -0500 Original-Received: from mail-we0-f172.google.com ([74.125.82.172]:40277) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2JVZ-0001pP-GL for 10489@debbugs.gnu.org; Tue, 28 Feb 2012 04:38:15 -0500 Original-Received: by werb10 with SMTP id b10so1557582wer.3 for <10489@debbugs.gnu.org>; Tue, 28 Feb 2012 01:34:58 -0800 (PST) Received-SPF: pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.180.92.73 as permitted sender) client-ip=10.180.92.73; Authentication-Results: mr.google.com; spf=pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.180.92.73 as permitted sender) smtp.mail=thierry.volpiatto@gmail.com; dkim=pass header.i=thierry.volpiatto@gmail.com Original-Received: from mr.google.com ([10.180.92.73]) by 10.180.92.73 with SMTP id ck9mr36674209wib.2.1330421698079 (num_hops = 1); Tue, 28 Feb 2012 01:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=/3ld4Ck2IeaPr0nCd1QEKqhxVKDGXAiT3IIbYn7DzLg=; b=d3pfuVQz7gAYi+A5WDRHOOqlVxiDDynVGufz4sp1oAOijbYWZw1+emExp75rCCqHMH gdfsc6jiVaUhdDYD+7/SHIl8w7pLn0XAP8PirjIFgzy7lGPYSQVrUgSyznsZ0iFamciq 9QgT8W3ej5w1U0CBlohH5PrRQZaMbwdREeqJE= Original-Received: by 10.180.92.73 with SMTP id ck9mr29012813wib.2.1330421698016; Tue, 28 Feb 2012 01:34:58 -0800 (PST) Original-Received: from thierry-MM061 (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id gf3sm27589552wib.6.2012.02.28.01.34.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 28 Feb 2012 01:34:56 -0800 (PST) In-Reply-To: <87pqczxsu0.fsf@gmx.de> (Michael Albinus's message of "Tue, 28 Feb 2012 09:31:03 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57348 Archived-At: Michael Albinus writes: > Thierry Volpiatto writes: > >> Hi Michael, > > Hi Thierry, > >>> `files-equal-p' still returns t for two non-existing files. Shall be >>> fixed too. >> Fixed. > > Looks good to me. Thanks! > >>> Btw, this is the only primitive function which has the prefix "files-", >>> all other start with prefix "file-". Is this necessary? >> I wrote files because comparing two files, but I don't care of this, >> just rename it to file- > > Thanks as well. I will change the name in Tramp once you have committed > your patch (or, even better, you do it in tramp.el when committing your > patch). Done (in tramp.el too) > Still some nit-picking :-) > >> -(defun files-equal-p (file1 file2) >> +(defun file-equal-p (file1 file2) >> "Return non-nil if FILE1 and FILE2 name the same file. >> Ordinary files are considered to be the same if `file-attributes' >> returns `equal' values for them." > > The file name handler implementation might not use `file-attributes' > (that's why we call the handler). Better, you don't say it such strictly > in the doc-string. Furthermore, I would like to see the phrase > "... existing files ..." somewhere. Done for "existing files", I have removed mention of `files-attributes' comparison, as I really don't know what to put there. I have fixed basically files.texi accordingly. I leave more sophisticated documentation about tramp handler to you. ;-) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997