From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ari Roponen Newsgroups: gmane.emacs.bugs Subject: bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text Date: Tue, 15 May 2012 13:07:08 +0300 Message-ID: <87fwb1dagj.fsf_-_@gmail.com> References: <87y5owjcto.fsf@gmail.com> <83pqa8vsxw.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337076498 1155 80.91.229.3 (15 May 2012 10:08:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 15 May 2012 10:08:18 +0000 (UTC) Cc: 11464@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 15 12:08:16 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SUEfq-0003n2-BY for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 May 2012 12:08:10 +0200 Original-Received: from localhost ([::1]:56893 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUEfp-00075x-ER for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 May 2012 06:08:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUEfi-00074X-0y for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 06:08:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUEff-0005gF-Kj for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 06:08:01 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUEff-0005g9-EZ for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 06:07:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SUEfi-0004UQ-2S for bug-gnu-emacs@gnu.org; Tue, 15 May 2012 06:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ari Roponen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 May 2012 10:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11464-submit@debbugs.gnu.org id=B11464.133707645517224 (code B ref 11464); Tue, 15 May 2012 10:08:02 +0000 Original-Received: (at 11464) by debbugs.gnu.org; 15 May 2012 10:07:35 +0000 Original-Received: from localhost ([127.0.0.1]:55356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUEfG-0004Tl-PI for submit@debbugs.gnu.org; Tue, 15 May 2012 06:07:35 -0400 Original-Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:36575) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUEfE-0004TZ-FZ for 11464@debbugs.gnu.org; Tue, 15 May 2012 06:07:33 -0400 Original-Received: by lagv3 with SMTP id v3so2616035lag.3 for <11464@debbugs.gnu.org>; Tue, 15 May 2012 03:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=9h9/mQIcPPCeM/jDhjyk9iAj9UJiNV6zDM9VQ8cy+w4=; b=S4jRiI8XGoU2DCyS8YsEF4+WXDKAEXGXwc9ylPZ3jLxzKwkPYXMwqeD6LxiM9HeIEn QtbjdR4QO8EMR8IYYIyhAVtAJHlbWuJGO64CvptaaWzDR4QYhMERA41iinQweoyjJRQI XiyGnvmAN5+JxVig2KAiGS6N1ryP+S/CvA8P7hTW2zjotQnbpgWKSdzizH9iK0IATsMM Q33Fj93rRhjDJJEHP0R9UPmPXvZV6yG9rv/aT+WsL1GxOFKSXSIQtuijQKyWcp/o779x 5s0bzuLNnPiMnkODAM3Htnlee5eSYTEKKVbCr1mZ/h9HFPUnBY7IkxZUJ/SFF/SZWMtr dIlA== Original-Received: by 10.152.109.198 with SMTP id hu6mr12504223lab.21.1337076441693; Tue, 15 May 2012 03:07:21 -0700 (PDT) Original-Received: from arirop (dsl-jklbrasgw1-fe82df00-79.dhcp.inet.fi. [80.223.130.79]) by mx.google.com with ESMTPS id k4sm27906594lbb.12.2012.05.15.03.07.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 15 May 2012 03:07:20 -0700 (PDT) In-Reply-To: <83pqa8vsxw.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 May 2012 21:26:03 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60021 Archived-At: Eli Zaretskii writes: > > But since the fix is quite simple, here you go: fixed in revision > 107994 on the emacs-24 branch. > Thank you. I can still reproduce the bug with that revision, but the following tweak seems to help. I'm not sure if it is correct, but at least it fixes the testcase, and everything else seems to work okay. === modified file 'src/xdisp.c' --- src/xdisp.c 2012-05-13 18:22:35 +0000 +++ src/xdisp.c 2012-05-15 09:51:45 +0000 @@ -1313,7 +1313,7 @@ visible_p = bottom_y > window_top_y; else if (top_y < it.last_visible_y) visible_p = 1; - if (bottom_y >= it.last_visible_y + if (bottom_y <= it.last_visible_y && it.bidi_p && it.bidi_it.scan_dir == -1 && IT_CHARPOS (it) < charpos) { -- Ari Roponen