From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#11757: Acknowledgement (24.1.50; vc-git calls `process-file' too many times) Date: Fri, 06 Jul 2012 15:44:44 +0200 Message-ID: <87fw95m2b7.fsf@gmx.de> References: <4FE2832A.1030308@yandex.ru> <4FE994E8.9020605@yandex.ru> <87zk7qs21q.fsf@gmx.de> <4FEBAAAA.3030102@yandex.ru> <87d34igrie.fsf@gmx.de> <4FEDD2A0.3010300@yandex.ru> <878vf66pgw.fsf@gmx.de> <4FEDDFD8.1010407@yandex.ru> <87wr2pgoiy.fsf@gmx.de> <4FEEF763.2060806@yandex.ru> <878vf5544d.fsf@gmx.de> <4FEF3A87.6000904@yandex.ru> <874nps63ki.fsf@gmx.de> <4FEF500A.9060103@yandex.ru> <87pq8f4xbv.fsf@gmx.de> <4FF062D7.7050402@yandex.ru> <878vf2sf7q.fsf@gmx.de> <4FF197A6.7060807@yandex.ru> <871ukrr297.fsf@gmx.de> <4FF47280.7040709@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1341582328 9958 80.91.229.3 (6 Jul 2012 13:45:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Jul 2012 13:45:28 +0000 (UTC) Cc: 11757@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 06 15:45:26 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sn8qX-0007y2-J9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2012 15:45:21 +0200 Original-Received: from localhost ([::1]:57034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn8qW-0000yu-Ki for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2012 09:45:20 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn8qO-0000ya-71 for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 09:45:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn8qI-0003vt-01 for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 09:45:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn8qH-0003t0-B6 for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 09:45:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sn8v4-0005Nj-Cm for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 09:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jul 2012 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11757 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11757-submit@debbugs.gnu.org id=B11757.134158259320665 (code B ref 11757); Fri, 06 Jul 2012 13:50:02 +0000 Original-Received: (at 11757) by debbugs.gnu.org; 6 Jul 2012 13:49:53 +0000 Original-Received: from localhost ([127.0.0.1]:51644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sn8uu-0005NG-Kt for submit@debbugs.gnu.org; Fri, 06 Jul 2012 09:49:53 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:52644) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1Sn8us-0005N7-5d for 11757@debbugs.gnu.org; Fri, 06 Jul 2012 09:49:51 -0400 Original-Received: (qmail invoked by alias); 06 Jul 2012 13:44:49 -0000 Original-Received: from p57BB9115.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.145.21] by mail.gmx.net (mp029) with SMTP; 06 Jul 2012 15:44:49 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1/TAilKpF7TKmQJIgGNwNLS6XB1887kcGY5yZ/awT jLwpFcj4qYxZkP In-Reply-To: <4FF47280.7040709@yandex.ru> (Dmitry Gutov's message of "Wed, 04 Jul 2012 20:42:40 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61645 Archived-At: Dmitry Gutov writes: >> If we assume that there are no dangerous vc commands outside Emacs, we >> wouldn't have a problem. > > In this case, the behavior of the first patch I posted here should be > acceptable, right? It's simpler, has pretty much the same effect, and > should be a tiny bit faster. That I don't know. Both patches do almost what we expect, and having a cached value for `vc-registered' sounds more performant when applied often enough. >> Yes. I don't know, whether we will be able to handle any surprise when >> using caches. There will always be a scenario which lets fail a given >> algorithm. I fear. > > Sure, but I'm just asking for one scenario that works better with > explicitly caching 'git-registered, instead of not calling it in > vc-git-state'. > If `vc-git-state' doesn't call `vc-git-registered' (just assumes it's > t), then `vc-registered' is the latter's only client, and so its > return value is implicitly cached in 'vc-backend property. Maybe. Could you show a patch? (Please with ChangeLog entry, I would commit if it looks good). Best regards, Michael.