From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs,gmane.emacs.devel Subject: bug#11580: [PATCH] Fix bug #11580 Date: Wed, 26 Sep 2012 20:56:16 +0200 Message-ID: <87fw64ehpr.fsf@thinkpad.tsdh.de> References: <87ipb64w5x.fsf@riseup.net> <87mx0c655g.fsf@thinkpad.tsdh.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1348687005 9368 80.91.229.3 (26 Sep 2012 19:16:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Sep 2012 19:16:45 +0000 (UTC) Cc: 11580@debbugs.gnu.org, winkler@gnu.org, emacs-devel@gnu.org To: Sergio Durigan Junior Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 26 21:16:49 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TGx6E-0003RP-4N for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Sep 2012 21:16:46 +0200 Original-Received: from localhost ([::1]:51976 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGx69-0004Y5-2A for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Sep 2012 15:16:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGwnD-0004wE-Ip for bug-gnu-emacs@gnu.org; Wed, 26 Sep 2012 14:57:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGwn9-0007A2-6I for bug-gnu-emacs@gnu.org; Wed, 26 Sep 2012 14:57:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGwn9-00079s-2U for bug-gnu-emacs@gnu.org; Wed, 26 Sep 2012 14:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TGwn7-0007iO-T2 for bug-gnu-emacs@gnu.org; Wed, 26 Sep 2012 14:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Sep 2012 18:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11580 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: help Original-Received: via spool by 11580-submit@debbugs.gnu.org id=B11580.134868578529613 (code B ref 11580); Wed, 26 Sep 2012 18:57:01 +0000 Original-Received: (at 11580) by debbugs.gnu.org; 26 Sep 2012 18:56:25 +0000 Original-Received: from localhost ([127.0.0.1]:57372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TGwmW-0007hZ-UO for submit@debbugs.gnu.org; Wed, 26 Sep 2012 14:56:25 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:51634) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TGwmT-0007hR-Sd for 11580@debbugs.gnu.org; Wed, 26 Sep 2012 14:56:23 -0400 Original-Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 4277120DA9; Wed, 26 Sep 2012 14:56:20 -0400 (EDT) Original-Received: from frontend2.nyi.mail.srv.osa ([10.202.2.161]) by compute5.internal (MEProxy); Wed, 26 Sep 2012 14:56:21 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=IJpz+xVb1f/guK7S4YeeeimNmh0=; b=ry5Pb2d6hGXVuC9DencI951gK4B5 eFNLxUbVHf3+8CS7VkAuUbi8VevimJHgsexiiddf+3k82tuhbml0FbxfdHu0TXae U0DHUn+pHSbAckPehJg9H1AUX38G+vwrZvWQV+Msr7zwK/yp0Qj5rufbGBMZy+Ke SpJ4E2c3OxbuTn0= X-Sasl-enc: sAImkwNaePT73NDhIMv4efREpti+Cx33A3JTmeJXK29k 1348685780 Original-Received: from thinkpad.tsdh.de (unknown [91.67.8.160]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F3ED4825DF; Wed, 26 Sep 2012 14:56:20 -0400 (EDT) Mail-Followup-To: Sergio Durigan Junior , 11580@debbugs.gnu.org, winkler@gnu.org, emacs-devel@gnu.org In-Reply-To: (Sergio Durigan Junior's message of "Wed, 26 Sep 2012 15:18:40 -0300") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64929 gmane.emacs.devel:153597 Archived-At: Sergio Durigan Junior writes: Hi Sergio, > WDYT of the new patch below? --8<---------------cut here---------------start------------->8--- === modified file 'lisp/net/eudcb-bbdb.el' --- lisp/net/eudcb-bbdb.el 2012-01-19 07:21:25 +0000 +++ lisp/net/eudcb-bbdb.el 2012-09-26 18:14:52 +0000 @@ -166,7 +166,7 @@ (symbol-name attr))) 'record)))) (t - (setq val "Unknown BBDB attribute"))) + (error "Unknown BBDB attribute"))) (if val (cond ((memq attr '(phones addresses)) @@ -176,6 +176,8 @@ (setq eudc-rec (cons (cons attr (car val)) eudc-rec))) ((> (length val) 0) (setq eudc-rec (cons (cons attr val) eudc-rec))) + ((and (not (listp val)) (string= val "")) + nil) ; Do nothing (t (error "Unexpected attribute value"))))) (nreverse eudc-rec))) --8<---------------cut here---------------end--------------->8--- In the second hunk, the (not (listp val)) is not needed. If val was a list, it would have entered one of the two preceeding clauses, but that's just nitpicking. Anyway, only Roland knows exactly what's the right fix for the issue, so he should decide what to do. Bye, Tassilo