From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nathan Trapuzzano Newsgroups: gmane.emacs.bugs Subject: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Date: Fri, 08 Nov 2013 21:06:34 -0500 Message-ID: <87fvr69vmd.fsf@nbtrap.com> References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> <87zjpf5dgl.fsf@nbtrap.com> <87ob5vj6ut.fsf@nbtrap.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1383962838 14194 80.91.229.3 (9 Nov 2013 02:07:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Nov 2013 02:07:18 +0000 (UTC) Cc: 15814-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 09 03:07:22 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VexxJ-0002JT-6S for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Nov 2013 03:07:21 +0100 Original-Received: from localhost ([::1]:54076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VexxI-00027h-FW for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Nov 2013 21:07:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vexx9-00027X-Ra for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2013 21:07:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vexx2-0001Ai-Bc for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2013 21:07:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vexx0-0001AQ-Ia for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2013 21:07:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vexx0-0006x6-0n for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2013 21:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nathan Trapuzzano Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2013 02:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15814-done@debbugs.gnu.org id=D15814.138396280326698 (code D ref 15814); Sat, 09 Nov 2013 02:07:01 +0000 Original-Received: (at 15814-done) by debbugs.gnu.org; 9 Nov 2013 02:06:43 +0000 Original-Received: from localhost ([127.0.0.1]:43150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vexwg-0006wX-CZ for submit@debbugs.gnu.org; Fri, 08 Nov 2013 21:06:42 -0500 Original-Received: from oproxy7-pub.mail.unifiedlayer.com ([67.222.55.9]:51381) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1Vexwc-0006wM-NN for 15814-done@debbugs.gnu.org; Fri, 08 Nov 2013 21:06:40 -0500 Original-Received: (qmail 26040 invoked by uid 0); 9 Nov 2013 02:06:36 -0000 Original-Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy7.mail.unifiedlayer.com with SMTP; 9 Nov 2013 02:06:36 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=BiMpO/4QfvdE3iZkpRrulZFmTRqfJXiiMykb4btE36U=; b=HC7kvRS4WEqsKn6qBvT7U73tltqthwFFvQFn/lS+A6K9H/j8A48zdFDskOzVb+vvZIcwEb3GL+mhrD7rVp1kdjoNG9zO2bilAYDG8qKgnkTYH9mqBKzxFFh+QuweCrfu; Original-Received: from [50.90.253.209] (port=59837 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1Vexwa-0002za-9P; Fri, 08 Nov 2013 19:06:36 -0700 In-Reply-To: (Stefan Monnier's message of "Fri, 08 Nov 2013 14:06:48 -0500") User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80168 Archived-At: --=-=-= Content-Type: text/plain Stefan Monnier writes: >> We can make cconv work while preserving the malformed bindings, but when >> the compiler prints the warnings, there's a good chance that the >> malformed binding that gets printed will not look like the binding as it >> appears in the source, since cconv might transform the VALUE part. >> Therefore I think it's preferable to use byte-compile-log-warning in >> cconv. > > OK, fair enough, --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=cconv.el.patch # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: nbtrap@nbtrap.com-20131109010452-m4od51q5sllj5llv # target_branch: file:///home/nathan/opt/etc/bzr-repos/emacs/trunk/ # testament_sha1: a475ad3ca1826fb0b56abf8dfb460185dd5fd144 # timestamp: 2013-11-08 20:28:15 -0500 # base_revision_id: dgutov@yandex.ru-20131108112252-g8bofo4jray5k45v # # Begin patch === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2013-11-08 11:22:52 +0000 +++ lisp/ChangeLog 2013-11-09 01:04:52 +0000 @@ -1,3 +1,8 @@ +2013-11-09 Nathan Trapuzzano + + * emacs-lisp/cconv.el (cconv-convert): Print warning instead of + throwing error over malrofmed let/let*. + 2013-11-08 Dmitry Gutov * progmodes/ruby-mode.el (ruby-smie--indent-to-stmt): Use === modified file 'lisp/emacs-lisp/cconv.el' --- lisp/emacs-lisp/cconv.el 2013-11-04 19:48:07 +0000 +++ lisp/emacs-lisp/cconv.el 2013-11-08 16:50:27 +0000 @@ -291,9 +291,9 @@ (let* ((value nil) (var (if (not (consp binder)) (prog1 binder (setq binder (list binder))) - (cl-assert (null (cdr (cdr binder))) nil - "malformed let binding: `%s'" - (prin1-to-string binder)) + (when (cddr binder) + (byte-compile-log-warning + (format "Malformed `%S' binding: %S" letsym binder))) (setq value (cadr binder)) (car binder))) (new-val # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWRnlTkQABHp/gACwCwBS9/// XidMAP////BgCA+8Z97xsBoDebjpkOglRp2BKQU9UfqnpMI0PU/RTxGmoNMQDI0yaYAJJEYIGgFP U1GUZPU0MjQ0AABoOaYmTJowmCYmmATAIYIwIwCRTKTCnio9TyjRmmmo8k9Q0aA0Ho1D1DQEVJqY 1TGUaPUaZGgPUGjQAAAACKSNAJonpT0wQk/KZpqbSTTTEAaBo9RyIxPii2QhWaJaTPGncduwU8JV tiNejlnkn5/tvMJdOQlOOpSuAb3NjlYVVPCUSpJknRSakAoE03Ty47/u+HblepbjEaTGDr3iuhVg +PwkDIKposzzzxhBQczVnzJmW8O3DeZPBofIejbkpNvikmzmIX9/fCigsKsclOqZXLk6K8IJURVK oSssX65FBc9N8i4psuFhFEprxi9LHy0z56llkdMTTo6nvpfX9wGucy8pERWmxJiahjUYTHVuIWet qMIJ6KXNc3hHvMSSm5K4UVgwoMHdyHKGwGNwMwlxtoiMxmdpLeJxmCKGa7hudG9/lgS12QlJLkPX 8CsrKFy1wwc5znO8CJMQdlFDjO5M7vkFYTLBlQqwFW4sPfSbUPESeqVNiQMc/KuduONgShQqn86B pSjG2SFK4mcotzkZrWt3BeX9Q565LXMws82kPugaIGEXeOniyrFaksC9JIUsmqecNKN65oz3Yyzm hVnTwSt4oMgxLJiOyxUw0UkWoKR+uagB5RJSqlnQWC0rV+4/a2JQ7vTEXec5wIj7C0HCGE0n6IPc wkrEdzVpr2KBTYgwwRwaI9gyP8LTWDkG+2NMQvvcZ8PEXQLBcMOhGjLSVatY8SVIGIjaxGvYl1sS drtIyOovU8sGgGy3HwWOqwVhjO6K2tyyJnuERQPnohhFut/F6DCMUO3ObSNXJFqLAoDhYBu/Syb+ wUhyPCLJigtBOwKmw1kfQHMaQ2FZEBpQyikuGwJjelxBozaqaiYZSIUIc0LJFeTgmOPeiMvhD3is FujMMDFsRx35VaDujRgiOQNsdecqXmu1z58LblhY8kayhkr3q+TCHVGZoka0hoPtucYyRS5yxWKD IiWJ843Xo+QO5A4MS9F2HQyMqIsvckG8zMhiaVWphALaXi0L7t7wgobJifpDdw/xz4lnbvCDuD5S u7OIoao8V9XCZrjEHUdJrM3EDmxcDG5Q8VuoiGVKxpkee4OR5lB5kc+yeC0SrPpZWDLAW4Wpk1LQ zLcEoYoQaGE4yEpoYPWnMlo4Qyuq8Q2zQL0ttvZpW5UW31IS6QsvQ0DGfjXa4lkYkg9wwld5Yqgj 16pFUbbbcuisFbrK/KynUHgDpegmdh5Ms/72mnPSgVm6my6EdTa3+5q5okEcuoLXWeIUBoCkVcDX 1KyOgWYJm+oSbi0LhPPI1nX9ntQ8TeXITPDnPndNu7skOt7Q7neIuxPp3ozsMDT005yiCo++G3HM wc+RBBqmR0+WJk7MpWRb9SLU89ZWZRYkm8VPCkYkJsWHgceLWoKcDT8B2FV63IV1X0srELdva7Sc dU98iJ77W+B2aws5DSHEMDF01J8Q+BxYYOPI5FHOCmcNPlRUQ7966PVxPq3j1QjCMWZ0uxt6ik7K Ha2hBcrJb4izTlcZphGEy011nVgtPHF9yM/BYo3CW271ipb9608k1221ssCT3S9X0aRtMOXiayWs cEJSElsLmUbbH199kyo4NLNtdo3CSB1BYFAlyHyEqeLq2fJLPsknI3VGvtPXNOYTLqOwkSqkWNPj eRMYT2F+ofcJ/D3vY6dkBI6QHk7ghkTnCQGAeoKNyDYqDEdNB40OQNJszKUDgFYHAgwLEEgY9CRk JqZBwc0YOh9EIZTZjPQhsR9kDBMcXLgJ0QxvzwYRDXg7dzk2PbmNYP928ge1JeDsqaVxDwDftE7w k9Ym8TsEo8wv9ZBEBEA4A4MgdxWxCHvdDmY5CWh0uJ7qbx2Mx4OQ4lldaFHZ4eCDUMBS4hMCtYfZ G3udIqJ2KMK1QUK2qQcENCdLUaEJZzMOxDKDoDKDpzharhliSYMLliXEASDOhBK4ZwrqDikiv6w6 FaJSEkLJCCMrA6+JdSF6NQoxT0B3HkXOkBedzBexcsjYBYF7wEdeFKPtpQyqkE9NGT1osXskWe5h hCgbGG3bMJvArDihsTmP4CU8zDPRKJAyE2vUIvoHzDO0Vq1enUaHm5DUYeVlZZJGYb7u2ut2fEuA n9oST0z0HtKc3t4UPTLzrMuWrLYdBhmTZq8FDY7IYgiLzzG6oLmIcxcJSxXPEn6RjGe1kykzaHeM 33SZE2dreOtrQpChD+ZOq9xHQVF4SpCwMgizEWFMEK8DJyk4QbJnOv9CFr3sX7LzHYPqcHIZiTUD zGwdkZLkcEIoIjG4KqCiBwewNr7w8mn3I4RcwTCoMkHrDNLJlmHX0g4Rxdkgf8wUEeISBy7B/4u5 IpwoSAzypyIA --=-=-=--