unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: <nakayamakenjiro@gmail.com>,    Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: 16086@debbugs.gnu.org
Subject: bug#16086: 24.3.50; [PATCH] eww: New command and functions to list the browser histories..
Date: Thu, 12 Dec 2013 10:42:04 -0500	[thread overview]
Message-ID: <87fvpyqdo3.fsf@flea.lifelogs.com> (raw)
In-Reply-To: <87iouuwya5.fsf@dhcp-193-97.nrt.redhat.com> (nakayamakenjiro@gmail.com's message of "Thu, 12 Dec 2013 12:20:18 +0900")

On Thu, 12 Dec 2013 12:20:18 +0900 <nakayamakenjiro@gmail.com> wrote: 

>> Trailing spaces here and elsewhere, can you please fix?
> Oh, I'm sorry. I fixed them.
>> I'd rather see these removed, IIUC what you mean here.
> I think so too. I removed.

Cool, thanks.

>> Could this also bind `next-error' and `previous-error'?  Actually a
>> generic "list of items" buffer mode would be useful and perhaps already
>> exists?

> Ok, I will try to bind `next-error and `previous-error, but it may take
> a while.

It's very easy, in your case it's just moving up and down 1 line IIUC.
But it's not critical and you can even choose to leave it to me :)

I want to implement it for eww (to go back and forth between links) so I
thought it made sense.

> So, before I do that, I resend the patch with fixed of the above.

The patch looks OK, but please remind me, do we have contributor papers
from you?  It's a large patch.

(Lars, if you want to review the patch and commit it yourself, please
let me know.)

Thanks
Ted





  reply	other threads:[~2013-12-12 15:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-08  5:44 bug#16086: 24.3.50; [PATCH] eww: New command and functions to list the browser histories Kenjiro NAKAYAMA
2013-12-11  0:21 ` Ted Zlatanov
2013-12-11 19:07   ` Ted Zlatanov
2013-12-12  3:20     ` nakayamakenjiro
2013-12-12 15:42       ` Ted Zlatanov [this message]
2013-12-12 23:54         ` Kenjiro NAKAYAMA
2013-12-13 14:39           ` Ted Zlatanov
2013-12-14  1:48             ` Kenjiro NAKAYAMA
2013-12-14 15:56               ` Stefan Monnier
2013-12-14 16:15         ` Lars Magne Ingebrigtsen
2013-12-20  0:53           ` Kenjiro NAKAYAMA
2013-12-21 20:34             ` Ted Zlatanov
2013-12-21 20:34             ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvpyqdo3.fsf@flea.lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=16086@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=nakayamakenjiro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).