From: Ivan Shmakov <ivan@siamics.net>
To: 19274@debbugs.gnu.org
Subject: bug#19274: tar-mode.el: allow for adding new archive members
Date: Fri, 05 Dec 2014 20:20:24 +0000 [thread overview]
Message-ID: <87fvctn913.fsf@violet.siamics.net> (raw)
In-Reply-To: <jwvwq666e8c.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Thu, 04 Dec 2014 21:10:18 -0500")
>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
[…]
>> + ;; omit tar-header-checksum (tar-chk-offset) for now
> Please capitalize and punctuate your comments.
Even the one-line ones?
Given that I have some time to improve this patch, could someone
please suggest a good place to add a menu entry for
tar-new-entry in tar-mode-map? (I never use Emacs’ menus
myself, so I’m rather clueless on this.)
BTW, I wonder if it makes sense to split the make-tar-header
form (with all the nil’s there) off tar-new-entry into a new
(tar-new-regular-file-header filename &optional size time)
function? I guess that’d ease the creation of Tar archives from
Emacs Lisp code; (and I already imagine some uses to that.)
I’ll also write a proper docstring for tar-header-serialize, so
to make it clear this function is part of the module’s external
interface.
PS. you know you may be a mathematician if your sentences start with a
lower-case letter and end with a semicolon;
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A.
next prev parent reply other threads:[~2014-12-05 20:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 21:17 bug#19274: tar-mode.el: allow for adding new archive members Ivan Shmakov
2014-12-05 2:10 ` Stefan Monnier
2014-12-05 20:20 ` Ivan Shmakov [this message]
2014-12-06 5:09 ` Stefan Monnier
2014-12-06 19:17 ` Ivan Shmakov
2014-12-06 19:33 ` Eli Zaretskii
2014-12-06 19:45 ` Ivan Shmakov
2014-12-06 19:56 ` Eli Zaretskii
2014-12-06 20:04 ` Ivan Shmakov
2014-12-06 20:15 ` Eli Zaretskii
2014-12-06 20:50 ` Ivan Shmakov
2014-12-07 16:20 ` Eli Zaretskii
2014-12-07 17:47 ` Ivan Shmakov
2014-12-07 17:58 ` Eli Zaretskii
2014-12-07 18:07 ` Ivan Shmakov
2015-01-27 22:04 ` Ivan Shmakov
2014-12-06 23:13 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvctn913.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=19274@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).