From: Juri Linkov <juri@linkov.net>
To: asparagus@comcast.net
Cc: 20626@debbugs.gnu.org
Subject: bug#20626: Wishlist: M-x shell-command-on-rectangle-region
Date: Tue, 16 Jun 2015 00:45:27 +0300 [thread overview]
Message-ID: <87fv5s4pm0.fsf@mail.linkov.net> (raw)
In-Reply-To: <87twv51raf.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 22 May 2015 01:47:52 +0300")
>> Wishlist:
>> M-x shell-command-on-rectangle-region
>
> As you can see in bug#20070, the effort to make commands rectangleable
> had stalled some time ago due to the need to decide how to handle
> backward-compatibility of the existing region arguments, e.g. in
>
> (shell-command-on-region START END COMMAND &optional OUTPUT-BUFFER REPLACE
> ERROR-BUFFER DISPLAY-ERROR-BUFFER)
>
> how to send the boundaries of the rectangular region in START and END.
>
> One idea is to handle it like recently we handled backward-compatibility
> for saving dired positions in saveplace.el where we used a new format like
>
> ("~" (dired-filename . "~/.emacs.d/places"))
>
> Using something like this means sending the rectangular bounds
> either in START or END in the new format like
>
> (rect (1 . 2) (3 . 4))
Sorry, I was wrong. I realized now that query-replace has quite
a different requirement. query-replace needs rectangular boundaries
to limit the search for replacements, whereas shell-command-on-region
should extract the rectangular region as strings and replace it with
the result of the command. Here is a working prototype that demonstrates
its possible implementation:
(define-advice shell-command-on-region
(:around (orig-fun start end command
&optional output-buffer replace
error-buffer display-error-buffer))
(if (and (boundp 'rectangle-mark-mode) rectangle-mark-mode)
(let ((input (mapconcat 'identity (delete-extract-rectangle start end) "\n"))
output)
(with-temp-buffer
(insert input)
(call-process-region (point-min) (point-max)
shell-file-name t t
nil shell-command-switch
command)
(setq output (split-string (buffer-string) "\n")))
(goto-char start)
(insert-rectangle output))
(funcall orig-fun start end command
output-buffer replace
error-buffer display-error-buffer)))
This is another case to take into account when designing the interface,
i.e. in this case the list of boundaries in the arg START is not necessary,
and I have no idea how to avoid `(if (and (boundp 'rectangle-mark-mode)
rectangle-mark-mode))'
next prev parent reply other threads:[~2015-06-15 21:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1119163948.10099018.1432245074823.JavaMail.zimbra@comcast.net>
2015-05-21 22:04 ` bug#20626: Wishlist: M-x shell-command-on-rectangle-region asparagus
2015-05-21 22:47 ` Juri Linkov
2015-06-15 21:45 ` Juri Linkov [this message]
2015-06-22 22:37 ` Juri Linkov
2015-06-23 2:02 ` Stefan Monnier
2015-06-23 22:59 ` Juri Linkov
2015-06-23 23:50 ` Stefan Monnier
2015-06-24 22:27 ` Juri Linkov
2015-06-25 3:45 ` Stefan Monnier
2015-06-25 22:30 ` Juri Linkov
2015-06-26 1:53 ` Stefan Monnier
2015-06-30 20:44 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv5s4pm0.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=20626@debbugs.gnu.org \
--cc=asparagus@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).