From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#20832: 25.0.50; todo-show accidentally deleted my todo file. Date: Fri, 19 Jun 2015 17:14:31 +0200 Message-ID: <87fv5nivc8.fsf@gmx.net> References: <86h9q67v0w.fsf@members.fsf.org> <87fv5pcogr.fsf@gmx.net> <5582B0F5.30303@members.fsf.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1434726930 9199 80.91.229.3 (19 Jun 2015 15:15:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Jun 2015 15:15:30 +0000 (UTC) Cc: 20832-done@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 19 17:15:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z5y0c-0006bK-V1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Jun 2015 17:15:11 +0200 Original-Received: from localhost ([::1]:58613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5y0c-00057B-BE for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Jun 2015 11:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5y0Z-00054G-7G for bug-gnu-emacs@gnu.org; Fri, 19 Jun 2015 11:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5y0W-00054d-0n for bug-gnu-emacs@gnu.org; Fri, 19 Jun 2015 11:15:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5y0V-000542-TC for bug-gnu-emacs@gnu.org; Fri, 19 Jun 2015 11:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z5y0V-0007cF-NH for bug-gnu-emacs@gnu.org; Fri, 19 Jun 2015 11:15:03 -0400 In-Reply-To: <86h9q67v0w.fsf@members.fsf.org> Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Jun 2015 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 20832 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 20832@debbugs.gnu.org, stephen.berman@gmx.net, youngfrog@members.fsf.org Original-Received: via spool by 20832-done@debbugs.gnu.org id=D20832.143472688829231 (code D ref 20832); Fri, 19 Jun 2015 15:15:02 +0000 Original-Received: (at 20832-done) by debbugs.gnu.org; 19 Jun 2015 15:14:48 +0000 Original-Received: from localhost ([127.0.0.1]:52090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5y0F-0007bP-PC for submit@debbugs.gnu.org; Fri, 19 Jun 2015 11:14:48 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:59330) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5y0D-0007bB-Ge for 20832-done@debbugs.gnu.org; Fri, 19 Jun 2015 11:14:46 -0400 Original-Received: from rosalinde ([89.245.121.189]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MMkgl-1ZCHv52aZb-008Xv9; Fri, 19 Jun 2015 17:14:32 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:uGhzWVvBc/SraRRDoUjKwAMzDUjYWrVJX8mIOGgZtgMt5rdbMRq yP1WF6rwda/M/RA3cWcgVeK3zF2NoF2ooYKg9QnueZlUzY+p6PQPKHYXqKGe8yiDlaklpQs KxhaZ+M1r2uFIV3zly47rnWCUuIbQF2YYQj/bGpZLXGlln51kziD3yMZSGsbjNEK8YdOX4m hZcgEZMlWcpGU4PzL7EGw== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104120 Archived-At: On Thu, 18 Jun 2015 13:52:21 +0200 Nicolas Richard wrote: > Le 18/06/2015 12:15, Stephen Berman a =C3=A9crit : >> But if there are other >> triggers, then your patch may be needed. However, since I haven't found >> any other way to make the problem you encountered occur, I'm inclined to >> install just the patch below; that way, if there is some other way to >> get an empty but modified todo-mode buffer, we may find it and be able >> to fix the underlying cause. > > Throwing an error seemed like a good way to find such problems, to me, > better so than silently deleting the file. That's true, I guess it's better to be safe than sorry. >> The following patch makes todo-show display the todo file in the >> previous window when invoked in the minibuffer. An alternative would be >> to simply error out when invoking todo-show in the minibuffer. But I >> think it could be useful to display the todo file while in the >> minibuffer. Do you see a problem with this? > > I don't see a need for (with-selected-window) You're right, it's unnecessary; thanks for noticing. (I had first tried to fix it without that macro and on testing it changed the selected window from the minibuffer to the todo-mode buffer, so that's why I thought I needed with-selected-window, but I must have used different functions, I can't remember anymore.) I installed both patches in separate commits to keep the author credits clear (with a slightly tweaked error message in your patch) and am closing this bug. Thanks again. Steve Berman