From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#20925: 25.0.50; isearch-exit calls isearch-done twice Date: Tue, 30 Jun 2015 01:07:08 +0300 Organization: LINKOV.NET Message-ID: <87fv5a184z.fsf@mail.linkov.net> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1435615762 7315 80.91.229.3 (29 Jun 2015 22:09:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Jun 2015 22:09:22 +0000 (UTC) Cc: 20925@debbugs.gnu.org To: Katsumi Yamaoka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 30 00:09:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z9hEk-0005U1-Qt for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jun 2015 00:09:10 +0200 Original-Received: from localhost ([::1]:44221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9hEk-0003Jh-1s for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jun 2015 18:09:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9hEg-0003Ft-Mt for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 18:09:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9hEc-0007Jv-M3 for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 18:09:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9hEc-0007JX-Iq for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 18:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z9hEc-0004Ah-7t for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 18:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 22:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20925 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20925-submit@debbugs.gnu.org id=B20925.143561569115973 (code B ref 20925); Mon, 29 Jun 2015 22:09:02 +0000 Original-Received: (at 20925) by debbugs.gnu.org; 29 Jun 2015 22:08:11 +0000 Original-Received: from localhost ([127.0.0.1]:33385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9hDm-00049Y-GV for submit@debbugs.gnu.org; Mon, 29 Jun 2015 18:08:10 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:33308 helo=homiemail-a75.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9hDk-00049P-DG for 20925@debbugs.gnu.org; Mon, 29 Jun 2015 18:08:08 -0400 Original-Received: from homiemail-a75.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a75.g.dreamhost.com (Postfix) with ESMTP id A73E15EC084; Mon, 29 Jun 2015 15:08:06 -0700 (PDT) Original-Received: from localhost.linkov.net (m83-191-202-36.cust.tele2.ee [83.191.202.36]) (Authenticated sender: jurta@jurta.org) by homiemail-a75.g.dreamhost.com (Postfix) with ESMTPA id AD6395EC081; Mon, 29 Jun 2015 15:08:05 -0700 (PDT) In-Reply-To: (Katsumi Yamaoka's message of "Mon, 29 Jun 2015 18:27:18 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104513 Archived-At: > `isearch-exit' calls `isearch-done' by way of `isearch-edit-string' > and `with-isearch-suspended', and then calls it again. > I don't know why it does so but this change gets rid of the error: > > --- isearch.el~ 2015-06-28 22:04:38.000000000 +0000 > +++ isearch.el 2015-06-29 09:26:19.216444200 +0000 > @@ -1184,8 +1184,8 @@ > (if (and search-nonincremental-instead > (=3D 0 (length isearch-string))) > (let ((isearch-nonincremental t)) > - (isearch-edit-string))) > - (isearch-done) > + (isearch-edit-string)) > + (isearch-done)) > (isearch-clean-overlays)) Thanks, I believe this is the right fix to avoid calling =E2=80=98isearch-done=E2=80=99 twice. Could you please add a short 1-lin= e comment explaining that =E2=80=98isearch-edit-string=E2=80=99 already calls =E2=80= =98isearch-done=E2=80=99.