From: Juri Linkov <juri@linkov.net>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: 22147@debbugs.gnu.org
Subject: bug#22147: Obsolete search-forward-lax-whitespace
Date: Mon, 30 May 2016 23:57:12 +0300 [thread overview]
Message-ID: <87fusz2riv.fsf@mail.linkov.net> (raw)
In-Reply-To: <87bn436qx5.fsf@gmail.com> (Artur Malabarba's message of "Wed, 18 May 2016 17:40:22 -0300")
>> Now I tried to reintroduce these lists with different names:
>> ‘char-fold-include-alist’ with a list to add to default mappings and
>> ‘char-fold-exclude-alist’ with a list to remove from default mappings
>> taking into account all opinions expressed on emacs-devel for the
>> default values:
>
> Sounds good! Some minor comments:
>
>> +(defun make-char-fold-table ()
>
> Call this `char-fold--make-table'
>
>> + (unless (and (assq char char-fold-exclude-alist)
>> + (member (apply #'string decomp) (assq char char-fold-exclude-alist)))
>
> This call to `member' will run dozens of times for each entry in
> `char-fold-exclude-alist'. Maybe we should optimize those two repeated
> forms: `(apply #'string decomp)' and `(assq char char-fold-exclude-alist)'.
This definitely needs to be optimized, but now it's clear there is no hurry
since this is not going to be released in 25. Moreover, I get occasional crashes
in char-tables with the latest patch, so it was a good thing not to push
it to the release branch at the last minute.
next prev parent reply other threads:[~2016-05-30 20:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 23:52 bug#22147: Obsolete search-forward-lax-whitespace Juri Linkov
2015-12-12 0:44 ` Artur Malabarba
2015-12-12 23:31 ` Juri Linkov
2015-12-13 0:29 ` Artur Malabarba
2015-12-14 0:23 ` Juri Linkov
2015-12-14 1:11 ` Artur Malabarba
2015-12-14 23:58 ` Juri Linkov
2015-12-15 10:15 ` Artur Malabarba
2015-12-16 0:57 ` Juri Linkov
2015-12-16 1:47 ` Drew Adams
2016-05-14 20:45 ` Juri Linkov
2016-05-14 22:20 ` Artur Malabarba
2016-05-14 22:27 ` Drew Adams
2016-05-15 20:45 ` Juri Linkov
2016-05-14 22:22 ` Drew Adams
2016-05-15 20:56 ` Juri Linkov
2016-05-15 21:51 ` Drew Adams
2016-05-17 20:55 ` Juri Linkov
2016-05-17 21:55 ` Drew Adams
2016-05-18 3:00 ` Artur Malabarba
2016-05-18 19:34 ` Juri Linkov
2016-05-18 20:40 ` Artur Malabarba
2016-05-30 20:57 ` Juri Linkov [this message]
2016-06-01 15:03 ` Artur Malabarba
2020-09-05 14:54 ` Lars Ingebrigtsen
2020-09-07 18:34 ` Juri Linkov
2015-12-16 10:59 ` Artur Malabarba
2015-12-17 0:57 ` Juri Linkov
2015-12-17 16:33 ` Artur Malabarba
2015-12-17 17:21 ` Drew Adams
2015-12-17 18:47 ` Artur Malabarba
2015-12-17 22:16 ` Drew Adams
2015-12-18 0:55 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fusz2riv.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=22147@debbugs.gnu.org \
--cc=bruce.connor.am@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).