bug#24423: Proposal to set buffer not-modified when downloading a sieve script

bug#24423: Proposal to set buffer not-modified when downloading a sieve script

[TSUCHIYA Masatoshi]

[-- Attachment #1.1: Type: text/plain, Size: 468 bytes --]

Hi,

Because sieve-edit-script() does not set buffer not-modified when
downloading a sieve script, so, a user including muself cannot
distinguish whether the viewing script is modified or not modified from
the downloaded script on the managesieve server.

If sieve-edit-script() set buffer not-modified when downloading a sieve
script, a user can distinguish its modified status easily.

Therefore, I propose the following patch.

-- 
TSUCHIYA Masatoshi

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Type: text/x-diff, Size: 442 bytes --]

--- a/lisp/sieve.el
+++ b/lisp/sieve.el
@@ -207,7 +207,8 @@ require \"fileinto\";
 	      err)
 	  (setq err (sieve-manage-getscript name newbuf sieve-manage-buffer))
 	  (switch-to-buffer newbuf)
-	  (unless (sieve-manage-ok-p err)
+	  (if (sieve-manage-ok-p err)
+	      (set-buffer-modified-p nil)
 	    (error "Sieve download failed: %s" err)))
       (switch-to-buffer (get-buffer-create "template.siv"))
       (insert sieve-template))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 180 bytes --]

bug#24423: Proposal to set buffer not-modified when downloading a sieve script

[Katsumi Yamaoka]

On Mon, 12 Sep 2016 16:03:18 -0400, TSUCHIYA Masatoshi wrote:
> Because sieve-edit-script() does not set buffer not-modified when
> downloading a sieve script, so, a user including muself cannot
> distinguish whether the viewing script is modified or not modified from
> the downloaded script on the managesieve server.

> If sieve-edit-script() set buffer not-modified when downloading a sieve
> script, a user can distinguish its modified status easily.

> Therefore, I propose the following patch.

The patch looks fine and useful.  I've committed it in the Emacs
master with this log entry:

sieve.el: Make the buffer to edit unmodified initially (bug#24423)

* lisp/net/sieve.el (sieve-edit-script):
Make the buffer to edit be not modified-p initially (bug#24423).

Thanks.