From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation Date: Mon, 12 Sep 2016 20:56:22 -0700 Message-ID: <87fup41mhl.fsf@secretsauce.net> References: <87ha4jgw53.fsf@secretsauce.net> <87si0ion1c.fsf@gnus.org> <87k2et8hr4.fsf@secretsauce.net> <83a8fpe1dr.fsf@gnu.org> <87h99w8ynv.fsf@secretsauce.net> <87k2es9weh.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1473740016 24732 195.159.176.226 (13 Sep 2016 04:13:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Sep 2016 04:13:36 +0000 (UTC) User-Agent: mu4e 0.9.17; emacs 25.1.1 Cc: Andreas Schwab , 17544@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 13 06:13:32 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjf66-0005KI-HK for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Sep 2016 06:13:26 +0200 Original-Received: from localhost ([::1]:46403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjf64-0004ge-DC for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Sep 2016 00:13:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjeqJ-0000om-FR for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 23:57:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjeqG-00044e-9T for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 23:57:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjeqE-00044I-0l for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 23:57:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bjeqD-0000jg-ML for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 23:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2016 03:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17544-submit@debbugs.gnu.org id=B17544.14737389862784 (code B ref 17544); Tue, 13 Sep 2016 03:57:01 +0000 Original-Received: (at 17544) by debbugs.gnu.org; 13 Sep 2016 03:56:26 +0000 Original-Received: from localhost ([127.0.0.1]:58102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjepe-0000iq-0v for submit@debbugs.gnu.org; Mon, 12 Sep 2016 23:56:26 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjepc-0000ii-OZ for 17544@debbugs.gnu.org; Mon, 12 Sep 2016 23:56:25 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 462B6206F2; Mon, 12 Sep 2016 23:56:24 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Mon, 12 Sep 2016 23:56:24 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=/K5tm EjWqzKMMtz+vYQo6b6bgks=; b=Q+4NYb0SzoQG9liSprFwP8eEdVabnHLRB7nXm 6LXYa+jRncL0PNrNeK92sstfzFgPPYXyagi7tv4fBN/I3gE6cO6sD0Rf00U9b2sF jmin8qCzbxmePrHZjIo9bhavbJiFQc+eEk7mGi6xO0SQr0tqdhVuKyz4jzy8ftj4 hsdbSc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=/K5tmEjWqzKMMtz+vYQo6b6bgks=; b=e9bEG GjFe5wewnUSQuD/vjox9qzkqLW1I6A9wNRbtajoktkBcr8bU7VreVnu6UL9Vz33b JhOF/wYX5+nxd9WJi1iPE6Iev6iUwY9AOOCeZdtP9plxsimKKCSWQpL9BPdq7GwE SRbBnZhBl4skpQM7zbDwz3exkBLCypDaNMEU/g= X-Sasl-enc: MKXtA+p+DOVDCJ7FTed4+lYbecOMB3oQWPlVsb5KEi0i 1473738983 Original-Received: from scrawny (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id E5FCCF29CF; Mon, 12 Sep 2016 23:56:23 -0400 (EDT) Original-Received: from [::1] (helo=scrawny) by scrawny with esmtp (Exim 4.87) (envelope-from ) id 1bjepa-00041j-FV; Mon, 12 Sep 2016 20:56:22 -0700 In-reply-to: <87k2es9weh.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123241 Archived-At: npostavs@users.sourceforge.net writes: > Dima Kogan writes: c> >> >>> and the whole issue of testing called-interactively-p that goes with >>> it. Can you explain? >> >> I'm guessing the interactivity checking in diff-hunk-next and >> diff-hunk-prev was intended to keep scripts working as before. Again, it >> has been too long to remember specifically. > > IMO, it would make more sense to just define your new commands directly, > something like: > > (defun diff-hunk-next-command (&optional count) > "." > (interactive "p") > (let ((start (point))) > (let ((hunk-bounds (diff-bounds-of-hunk))) > (goto-char (car hunk-bounds))) > (diff-hunk-next count) > (when (not (looking-at diff-hunk-header-re)) > (goto-char start) > (user-error "No next hunk")))) > > And then just give the *binding* of `diff-hunk-next' to > `diff-hunk-next-command'. No need to make a higher order wrapper > function just for defining 2 functions.