From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.bugs Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Date: Thu, 15 Sep 2016 14:57:24 -0700 Message-ID: <87fup03jy3.fsf@cochranmail.com> References: <87fup2nkry.fsf@cochranmail.com> <87k2ecalre.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1473976711 1227 195.159.176.226 (15 Sep 2016 21:58:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Sep 2016 21:58:31 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Chunyang Xu , 24362@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 15 23:58:26 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkefi-0007iP-Vi for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Sep 2016 23:58:20 +0200 Original-Received: from localhost ([::1]:37601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkefh-0001yM-4v for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Sep 2016 17:58:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkefY-0001yD-1j for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 17:58:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkefS-0001mQ-6K for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 17:58:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkefR-0001m9-TK for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 17:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bkefR-0001ZD-Nb for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 17:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2016 21:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.14739766545985 (code B ref 24362); Thu, 15 Sep 2016 21:58:01 +0000 Original-Received: (at 24362) by debbugs.gnu.org; 15 Sep 2016 21:57:34 +0000 Original-Received: from localhost ([127.0.0.1]:60828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkeez-0001YT-UV for submit@debbugs.gnu.org; Thu, 15 Sep 2016 17:57:34 -0400 Original-Received: from mail.workgrouplinux.net ([207.195.177.82]:57671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkeex-0001YG-NM for 24362@debbugs.gnu.org; Thu, 15 Sep 2016 17:57:32 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=tqZ3HF8hYBUDMWxoFh8GVJuwG0k=; b=omFRB DzkM+pyN3KGXD5pQHszCkcAd+eEY9aROGOUjNaughPbNrxTG5vW05/O0CskZVJFq 9yhWJ9Tly0hhcU+D/l0pMmiBpK2qMuVo/xb+g9RqBtZemBPfF4d5vPHBdulz5X02 c5RzL7OdoU4Bai6ETZxvKJ9+8dvezU782dEz8Y2pJ02ktjtXGCWZnXxDt0NJl31d N890lpwLFySEAqyqCK3vhlUDRGaLWbLNopdFoqSItVq4Yr2YH6Yszj6bdTfsu15f FBMyBOYqmBDyygazTy4ntY6zndxsqZ2zgd5PXaFHTwOQ0odxy2dK59fMiAzQiMoe lKGxKVhojGFSJov3Q== Original-Received: (qmail 22081 invoked by uid 0); 15 Sep 2016 21:57:29 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=KrZC++qnQOJZYI6spHkmFQxmCOIz7pPiVQSg8kRWN2iFPDimtM9G4vP/YOLhv3InZJHOMlwpq4kDawlZbv4Ksg==; Original-Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 15 Sep 2016 21:57:29 -0000 In-Reply-To: <87k2ecalre.fsf@web.de> (Michael Heerdegen's message of "Thu, 15 Sep 2016 23:36:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123362 Archived-At: Michael Heerdegen writes: > Robert Cochran writes: > >> This patch changes the pcase-let* docstring to match the pcase-let >> docstring, but IMO I don't think that the phrase 'a list of >> expressions' is exactly the right term for this. That (to me) implies >> that we are wrapping the whole body in a list, which you don't. > > Isn't this just normal "Elisp speak" for a &rest parameter? Sure, the > value of the parameter doesn't appear in the code (only "spliced in") - > but we use this wording all the time. It may very well be. I haven't been around long enough to know. Now, don't get me wrong, I *knew* what 'a list of expressions' had to mean in context (it wouldn't have worked any other way), but my natural parsing still evokes the wrong idea in my mind. If it's already established tradition, then I have no qualms. >> diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el >> index 0b8dddf..2d61642 100644 >> --- a/lisp/emacs-lisp/pcase.el >> +++ b/lisp/emacs-lisp/pcase.el >> @@ -261,7 +261,7 @@ pcase--let* >> ;;;###autoload >> (defmacro pcase-let* (bindings &rest body) >> "Like `let*' but where you can use `pcase' patterns for bindings. >> -BODY should be an expression, and BINDINGS should be a list of bindings >> +BODY should be a list of expressions, and BINDINGS should be a list of bindings > > Looks ok to me. Thanks! Not that there's much to do wrong there. ;) -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871