From: Alex <agrambot@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16728@debbugs.gnu.org, 16752@debbugs.gnu.org,
Helmut Eller <eller.helmut@gmail.com>
Subject: bug#16752: 24.3.50; pp-to-string deactivates mark
Date: Sun, 18 Sep 2016 17:55:25 -0600 [thread overview]
Message-ID: <87fuowvk42.fsf@gmail.com> (raw)
In-Reply-To: <jwv1tz5oaux.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Fri, 14 Feb 2014 12:42:25 -0500")
close 16728 25.1
quit
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> forcemerge 16728 16752
> thanks
>
>> Evaluating this expression returns:
>> (list deactivate-mark
>> (pp-to-string '1)
>> deactivate-mark)
>
> deactivate-mark is a global variable and lots of functions happen to
> work on internal buffers, which ends up "unwittingly" setting
> deactivate-mark to t.
>
> There are 2 directions to try and fix it:
> 1- let-bind deactivate-mark in functions like pp-to-string so as to
> eliminate those spurious deactivations. But there can be many of
> them, and it doesn't solve the problem where the buffer-modification
> is done in a non-temporary buffer.
> 2- make deactivate-mark buffer-local. This is "The Right Way" but
> might introduce new problems.
> E.g. we really should deactivate the mark in all the buffers that
> have their deactivate-mark set.
>
>
> Stefan
Looks like option 2 was chosen, and the test cases in both bugs now work
as expected, so I believe this is done. Please re-open if I'm wrong.
prev parent reply other threads:[~2016-09-18 23:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 9:46 bug#16752: 24.3.50; pp-to-string deactivates mark Helmut Eller
2014-02-14 10:11 ` Eli Zaretskii
2014-02-14 11:02 ` Helmut Eller
2014-02-14 11:16 ` Eli Zaretskii
2014-02-14 11:22 ` Eli Zaretskii
2014-02-14 11:23 ` Helmut Eller
2014-02-14 11:39 ` Eli Zaretskii
2014-02-14 17:42 ` Stefan Monnier
2014-02-14 18:17 ` Eli Zaretskii
2014-02-14 18:27 ` Helmut Eller
2014-02-14 18:38 ` Eli Zaretskii
2014-02-14 21:00 ` Stefan Monnier
2014-02-15 7:14 ` Eli Zaretskii
2014-02-17 3:11 ` Stefan Monnier
2014-02-17 5:31 ` Eli Zaretskii
2014-02-17 20:27 ` Stefan Monnier
2014-02-17 20:46 ` Eli Zaretskii
2014-02-18 0:05 ` Stefan Monnier
2014-02-18 8:31 ` Helmut Eller
2014-02-18 15:18 ` Eli Zaretskii
2014-02-18 15:33 ` Helmut Eller
2014-02-18 16:52 ` Eli Zaretskii
2016-09-18 23:55 ` Alex [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuowvk42.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=16728@debbugs.gnu.org \
--cc=16752@debbugs.gnu.org \
--cc=eller.helmut@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).