From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#26378: 26.0.50; Hitting 'n' during ediff gives Error Date: Thu, 06 Apr 2017 19:38:26 -0400 Message-ID: <87fuhlumx9.fsf@users.sourceforge.net> References: <87zifuv3q5.fsf@users.sourceforge.net> <87r315vh5a.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1491521893 23646 195.159.176.226 (6 Apr 2017 23:38:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Apr 2017 23:38:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: phst@google.com, 26378@debbugs.gnu.org To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 07 01:38:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwGyc-0005MJ-Ih for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Apr 2017 01:38:06 +0200 Original-Received: from localhost ([::1]:48054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwGyi-0002ik-1R for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Apr 2017 19:38:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwGyb-0002iN-RG for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2017 19:38:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwGyY-00037R-P9 for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2017 19:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwGyY-00037G-Li for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2017 19:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cwGyY-0000LV-6y for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2017 19:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Apr 2017 23:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26378-submit@debbugs.gnu.org id=B26378.14915218301270 (code B ref 26378); Thu, 06 Apr 2017 23:38:02 +0000 Original-Received: (at 26378) by debbugs.gnu.org; 6 Apr 2017 23:37:10 +0000 Original-Received: from localhost ([127.0.0.1]:35471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwGxh-0000KQ-OF for submit@debbugs.gnu.org; Thu, 06 Apr 2017 19:37:09 -0400 Original-Received: from mail-io0-f176.google.com ([209.85.223.176]:36633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwGxg-0000KD-B1 for 26378@debbugs.gnu.org; Thu, 06 Apr 2017 19:37:08 -0400 Original-Received: by mail-io0-f176.google.com with SMTP id l7so39987953ioe.3 for <26378@debbugs.gnu.org>; Thu, 06 Apr 2017 16:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=e6QBw4NGNUHNeePQQomXWIEIdLiIMby7cJWJ4DIjEUA=; b=lmXuOT333aRaD1KVZ3d9HY64iKV1j957kGgJfVoCcHkhcibtrtuxRRjvgeIMILvmTN 0gtGjasZ7CKBHbXMzvblrvKrOXdTQCvhXih8mS5XdwdidbHGLOj19jrKXHU22m7CIFgt /agOrV+hg1alabsg6mnUEy5/hUtJC/kj7TyIThoISWa7mjo8G1IWOFw/pSJ+NcPmdt4o 5HjMNR4e2NvUlzHiSPIhMikP8+F1soSUd+ocWDUZV6H82PBWlJhLFr9AQqynx0yObNSl 7PY+dkeAXm5fDlM4H8d3rCIF+qWxRBunW4iR0Da9DjUh2M8OKmkI4yl3tBc+c5FQ7zrC GJjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=e6QBw4NGNUHNeePQQomXWIEIdLiIMby7cJWJ4DIjEUA=; b=fOY2CimkHqZxy2j5jAMHcm4oqIiW8CP4Dd8BdJatuzyu7jP7cwS7Hv0GsxO7VXHw4G UDHLe8hVBpyrtZzYMb8SncicQZqzGragTqq9JxYZW3acxAlzSqYHWRFmyKV38pA7a0lO Y82Y3hSeR8ZUkHqvlAlgUoenTmDSgNCZXT3dv7uzICts5rT6awG9cCxbVTklcj5ee9CJ b1ESPNeSkor71629tAZXCksQa8wp9nfSUQNvQ3piCHP9YBSsCd/qJKsnv/9bT2rM/0T3 3lLxu2JmwTqHV4ZuSyNofKRRa4xq+Lauc4HkuazOI5QuaMG+rUCTkNQmo6TTeJgVQ3YW /J7w== X-Gm-Message-State: AN3rC/6yGF9Pj3d0OLq894z4ubwySPoVQmtvua0VsugGFFAZvJyMPyEcymCtAWuTV5ufuw== X-Received: by 10.107.144.193 with SMTP id s184mr1885766iod.88.1491521822841; Thu, 06 Apr 2017 16:37:02 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id l129sm720561ite.1.2017.04.06.16.37.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Apr 2017 16:37:02 -0700 (PDT) In-Reply-To: (Kaushal Modi's message of "Thu, 06 Apr 2017 14:36:58 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131317 Archived-At: Kaushal Modi writes: >> > +The PROGRAM is executed asynchronously unless `system-type' is >> > +`windows-nt' or `ms-dos', or unless SYNCH is non-nil. >> >> I think the second "unless" is redundant. >> > > I prefer repeating 'unless' in this case where the subject is changing from > system-type to SYNCH. It just adds clarity. Though, grammatically what you > suggested is also correct. So for reducing redundancy, I'll go with your > suggestion. Yeah, I guess it could go either way. > >> > I have tweaked this part slightly (see patch in this email). Based on the >> > code, nil and "" elements will be removed from a concatenated list of >> > OPTIONS and FILES; not just FILES. >> >> But OPTIONS can't have nil or "" in it (or any "elements", really), so I >> don't think there is any need to talk about that in the docstring. >> > > That's correct. I've updated the patch with what you suggested earlier. Thanks, I think this is ready to go in. Could you resend as an attachment? It doesn't seem to apply, possibly because of line wrapping and/or whitespace corruption.