unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: phst@google.com, 26378@debbugs.gnu.org
Subject: bug#26378: 26.0.50; Hitting 'n' during ediff gives Error
Date: Thu, 06 Apr 2017 19:38:26 -0400	[thread overview]
Message-ID: <87fuhlumx9.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CAFyQvY2egrq7TtWU3oK9og=Ex+B62X58=ctDtkgms7aQb9w+uA@mail.gmail.com> (Kaushal Modi's message of "Thu, 06 Apr 2017 14:36:58 +0000")

Kaushal Modi <kaushal.modi@gmail.com> writes:

>> > +The PROGRAM is executed asynchronously unless `system-type' is
>> > +`windows-nt' or `ms-dos', or unless SYNCH is non-nil.
>>
>> I think the second "unless" is redundant.
>>
>
> I prefer repeating 'unless' in this case where the subject is changing from
> system-type to SYNCH. It just adds clarity. Though, grammatically what you
> suggested is also correct. So for reducing redundancy, I'll go with your
> suggestion.

Yeah, I guess it could go either way.

>
>> > I have tweaked this part slightly (see patch in this email). Based on the
>> > code, nil and "" elements will be removed from a concatenated list of
>> > OPTIONS and FILES; not just FILES.
>>
>> But OPTIONS can't have nil or "" in it (or any "elements", really), so I
>> don't think there is any need to talk about that in the docstring.
>>
>
> That's correct. I've updated the patch with what you suggested earlier.

Thanks, I think this is ready to go in.  Could you resend as an
attachment?  It doesn't seem to apply, possibly because of line wrapping
and/or whitespace corruption.





  reply	other threads:[~2017-04-06 23:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 20:57 bug#26378: 26.0.50; Hitting 'n' during ediff gives Error Kaushal Modi
2017-04-05 21:03 ` Kaushal Modi
2017-04-05 21:20   ` Kaushal Modi
2017-04-05 21:53     ` Noam Postavsky
2017-04-05 22:36       ` Kaushal Modi
2017-04-05 23:23         ` npostavs
2017-04-06 12:23           ` Kaushal Modi
2017-04-06 12:45             ` npostavs
2017-04-06 14:36               ` Kaushal Modi
2017-04-06 23:38                 ` npostavs [this message]
2017-04-07 14:09                   ` Kaushal Modi
2017-04-07 22:31                     ` npostavs
2017-04-08 14:58                       ` Philipp Stephani
2017-04-10 19:36                         ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fuhlumx9.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=26378@debbugs.gnu.org \
    --cc=kaushal.modi@gmail.com \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).