From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex Date: Mon, 29 May 2017 20:11:37 -0400 Message-ID: <87fufn430m.fsf@users.sourceforge.net> References: <20170528204250.wjbrm2pul6cf6xam@odonien.localdomain> <83o9ucfl37.fsf@gnu.org> <20170529062859.mwoveygr5oh5iphz@odonien.localdomain> <87y3tfqz6c.fsf@SoraLaptop> <834lw3fnju.fsf@gnu.org> <20170529202021.ax4reeivfvlijkqv@odonien.localdomain> <87o9ubi5fq.fsf@SoraLaptop> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496103075 22729 195.159.176.226 (30 May 2017 00:11:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 00:11:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27122@debbugs.gnu.org, Vasilij Schneidermann To: Robert Cochran Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 30 02:11:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFUke-0005jG-Ob for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 May 2017 02:11:09 +0200 Original-Received: from localhost ([::1]:50931 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFUkj-00079B-SU for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 May 2017 20:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFUkc-000796-5C for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 20:11:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFUkY-0003XN-TQ for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 20:11:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41259) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFUkY-0003XH-L2 for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 20:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dFUkY-0007Ak-9F for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 20:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2017 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27122 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27122-submit@debbugs.gnu.org id=B27122.149610300827509 (code B ref 27122); Tue, 30 May 2017 00:11:02 +0000 Original-Received: (at 27122) by debbugs.gnu.org; 30 May 2017 00:10:08 +0000 Original-Received: from localhost ([127.0.0.1]:43936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFUjf-00079c-VD for submit@debbugs.gnu.org; Mon, 29 May 2017 20:10:08 -0400 Original-Received: from mail-it0-f54.google.com ([209.85.214.54]:38672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFUje-000794-9e for 27122@debbugs.gnu.org; Mon, 29 May 2017 20:10:06 -0400 Original-Received: by mail-it0-f54.google.com with SMTP id r63so33309525itc.1 for <27122@debbugs.gnu.org>; Mon, 29 May 2017 17:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mYV2lnix1vCgQ+aopGhZkyPmYQerCdtuuKYyzOntVWo=; b=YFmJuPC4hc/O6CPDDZlK4+oVObu4dfVpobs4a9LN7Cklbw0nbd9/q9yZeSwXTqqHWE 9wTEmdApZ0tbeNO04PjzHGoZAMC12Yn252i6RDMz87+2xbMWWkebUlSOnb8c4jq1K4lr bHTU2jwSGKKmuFHmibHS6cE6JX9cg4MigEqYeoNw+DBMKwEKzSVPKcKqVWuIfzO/XLL8 E0Q+0FoF2e8cMq332yKyOlcsEMUf83kHJ90mg0NfUoZk/j0uDFMwALct0L/zNWLfjBEY UZCNZfVVKdKriLakTootvFcLUPiVUujXD1nAf4g6GyzGMREx/Ie6kxc+xPtJR+ZtBRMK vQTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=mYV2lnix1vCgQ+aopGhZkyPmYQerCdtuuKYyzOntVWo=; b=fhLyz7v2legVKGz3P4OjDV4kj8BMfSXg3WpM17qZEZ54LtOTT/OSKFkgaXd0BJ27eU ztcU4EgoZ/gNBJjitHQ6AFLsa1hUAw3eBZ4bHwF5+rWMbti4/GbAZEejoA3ZiT+eutfL cXyorTHe3FvERm5pAp7fmUhpSL2CG0IdtxoySFaHkYkaVizrxs1mWGKTwTPPnRHQbSiI 9GRIWYmWoUWfpYF9C8rhdzaNYX0s4xEsBE+I42+8xAoKLETDrmSvGUriJRDAQzJEIkBP dgdNFisJKL74pagOFQeTAtaN6aWVpwn3lUSFJh59dTHMC2inRZeU4bVWQvJYArbU/h+k H9IQ== X-Gm-Message-State: AODbwcBP+N9KaLAh/1tOzS3ztWiLivYCrHCMpwGXvFZhHwvc9/6rCruw Q/p0AetW/vRWdg== X-Received: by 10.36.19.85 with SMTP id 82mr4606109itz.63.1496103000645; Mon, 29 May 2017 17:10:00 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id o4sm4788541ioe.46.2017.05.29.17.09.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 May 2017 17:10:00 -0700 (PDT) In-Reply-To: <87o9ubi5fq.fsf@SoraLaptop> (Robert Cochran's message of "Mon, 29 May 2017 16:55:37 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133024 Archived-At: Robert Cochran writes: > IMO, this is the best solution. But the size that the ensuing discussion > would inenvitably grow to puts me off of this path as well. I was > initially thinking that the current behavior was more long-standing (10+ > years), but it was actually introduced in its current form in 2010, in > d419e1d94 "Fix handling of 8-bit characters in a display table.". While I'm also okay with changing this to hex display without an option, I don't think that commit introduced the octal behaviour, it just changed the implementation. I think these these removed lines used to do it: - /* Insert three more glyphs into IT->ctl_chars for - the octal display of the character. */ - g = ((str[i] >> 6) & 7) + '0'; - XSETINT (it->ctl_chars[i * 4 + 1], g); - g = ((str[i] >> 3) & 7) + '0'; - XSETINT (it->ctl_chars[i * 4 + 2], g); - g = (str[i] & 7) + '0'; - XSETINT (it->ctl_chars[i * 4 + 3], g);