From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#24402: should-error doesn't catch all errors Date: Wed, 19 Jul 2017 22:04:03 -0600 Message-ID: <87fudrvjnw.fsf@lylat> References: <3654D8E9-D3CB-402B-922F-B132C1871E9F@runbox.com> <596E65D2-E780-43A1-A75B-603B61B6F9F4@runbox.com> <87zickhoco.fsf_-_@lylat> <877eznda7v.fsf@lylat> <874lur0zki.fsf@calancha-pc> <87o9sywtbz.fsf@lylat> <87fue3f9p8.fsf@users.sourceforge.net> <87vamyl3j3.fsf@lylat> <87tw2het1b.fsf@users.sourceforge.net> <874luhbo4l.fsf@lylat> <87lgntdswo.fsf@users.sourceforge.net> <87k23d9gvt.fsf@lylat> <87d195dmr0.fsf@users.sourceforge.net> <87lgns7y7g.fsf@lylat> <877ezbew3d.fsf@users.sourceforge.net> <87d193ljdp.fsf@lylat> <87shhxcqit.fsf@users.sourceforge.net> <87inithwi5.fsf@lylat> <87eftcglz3.fsf@runbox.com> <87y3rk9gfa.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1500523519 6351 195.159.176.226 (20 Jul 2017 04:05:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 20 Jul 2017 04:05:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Gemini Lasswell , 24402@debbugs.gnu.org, Tino Calancha To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 20 06:05:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dY2i4-000122-0t for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Jul 2017 06:05:08 +0200 Original-Received: from localhost ([::1]:35991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dY2i9-0000kt-E3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Jul 2017 00:05:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dY2i3-0000iw-Fe for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2017 00:05:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dY2hy-0002KK-GX for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2017 00:05:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45728) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dY2hy-0002Jp-Cb for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2017 00:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dY2hx-0001MQ-TK for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2017 00:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jul 2017 04:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 24402-submit@debbugs.gnu.org id=B24402.15005234595178 (code B ref 24402); Thu, 20 Jul 2017 04:05:01 +0000 Original-Received: (at 24402) by debbugs.gnu.org; 20 Jul 2017 04:04:19 +0000 Original-Received: from localhost ([127.0.0.1]:48405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dY2hH-0001LS-6o for submit@debbugs.gnu.org; Thu, 20 Jul 2017 00:04:19 -0400 Original-Received: from mail-it0-f68.google.com ([209.85.214.68]:34966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dY2hF-0001LE-CW for 24402@debbugs.gnu.org; Thu, 20 Jul 2017 00:04:17 -0400 Original-Received: by mail-it0-f68.google.com with SMTP id v127so1243565itd.2 for <24402@debbugs.gnu.org>; Wed, 19 Jul 2017 21:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=SONQATy7q7fn/VW87Yxf0920D0FDuKw2Ws/c5fFTuGY=; b=uB8hp/Vll1oQISS3atIUKWpJTOodf6oCsHmNDBpJIMqmb0rWOeu1dg4rMzjvdkeFOl 30f9BZeJ9Qj6osQGN+IJmgElY0vUddzR2vHfukfEAaNMQd4+JEuIdc0ldN5jLdEJ03WN G3P4rxIN3Qj5AZhVEQvev5hAKhsTv4364I2Ig/UVDhOhSzWfSNwIhkWXA/YnxXchU2jR 6eCWovgB+R6LYPnnshbOJ9SjfGxaAolVPxYaOeoskOSNKy3efHAOtX3CUYr+6QK4Vp/s 1vjNZaleBj2Bc/QixMSJz4GZAeh5ax/N3crs6UwSz7PfL3QELfOiVrpa8vyUsctkrcUz cBOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=SONQATy7q7fn/VW87Yxf0920D0FDuKw2Ws/c5fFTuGY=; b=oy/BCHX3MeGXtoqKlCY3FI+GfVRxFokl3nC1RJsGo6sH4Jd0kac3A4L0t/0Q458YOU LOpUrt2B/DQLrUSFDI+3DO39QV8KEFSQklfQJRms4kGalua0p2hzrv1saYYQ8tDxywID 3tALQ9rFmMUVXQCKT6UIlBgL9Irpu+csqIsJRqskMNIZevmt4emFNBCnWRv1ubbLrH+a zwZWHvHOcDJcR/yZI05bh3Db+O0kUjrhu5yP26RUqq8pbtYF6m+WNEFwN82tShkCkC1t 88LGzGwfiz7w8jgnBPFLeFryk7DnPx929FjECforiyO//dCyaHX0DcNVc6PDFdj0lG5V icUQ== X-Gm-Message-State: AIVw113t+B6jh+zedLAvXo4h5seT+InbqKHe8GrOp24lUap4q3ta8NGU VC+E6yJ3Lfjs+g== X-Received: by 10.36.142.193 with SMTP id h184mr2116543ite.4.1500523451772; Wed, 19 Jul 2017 21:04:11 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id a70sm821139ioe.88.2017.07.19.21.04.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Jul 2017 21:04:10 -0700 (PDT) In-Reply-To: <87y3rk9gfa.fsf@users.sourceforge.net> (npostavs's message of "Wed, 19 Jul 2017 19:04:57 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134777 Archived-At: npostavs@users.sourceforge.net writes: > Gemini Lasswell writes: > >> This is an excerpt of test/src/fns-tests.el with a few lines added at >> the end to invoke Testcover. It contains two nearly identical tests >> which should both pass, but one passes and one fails. > > If I run them again in the same Emacs session then they both fail. The > problem seems to be that testcover saves values produced in tests, and > when it tries to compare the 2 circular lists produced by these tests, a > `circular-list' error is thrown. In other words, this is actually a > totally separate bug (although it's hidden until a fix for #24402 is > applied). > > The following appears to fix it, though perhaps we should use a smarter > equal function that would consider the circular lists to actually be > equal instead of bailing out and returning nil on circularity. That would be nice. > Alex writes: >=20 > > Hmm, this isn't the behaviour that I see. I get the following errors > > both with and without my patch, and both interactively and in batch > > mode: > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > Edebug: cyc1 > > Edebug: test@test-cycle-assq > > Edebug: test@test-cycle-assoc > > Edebug: cyc1 > > Edebug: test@test-cycle-assq > > Edebug: test@test-cycle-assoc > > ... > > Edebug: cyc1 > > Edebug: test@test-cycle-assq > > Compiler-macro error for cl--block-wrapper: (error "Lisp nesting exceed= s =E2=80=98max-lisp-eval-depth=E2=80=99") >=20 > Hmm, that's strange, I don't get that error (or any "Edebug: cyc1" > repetitions after the first) on master, or with your patch. Whoops, I changed the defvar to a setq and forgot to change it back. Doing this results in the error I posted. (Which makes sense since it keeps reloading the file, resulting in the "Edebug:" loop. The compiler-macro errors and `t' being called as a function are a bit odd, though). I get the same behaviour as you and Gemini now. Sorry about the noise.