From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04 Date: Sat, 05 Aug 2017 13:08:11 +0900 Message-ID: <87fud6ejx0.fsf@calancha-pc> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1501906154 26605 195.159.176.226 (5 Aug 2017 04:09:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 5 Aug 2017 04:09:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: 27946@debbugs.gnu.org, Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 05 06:09:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddqOj-0006T3-Q5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Aug 2017 06:09:10 +0200 Original-Received: from localhost ([::1]:55296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddqOm-00018b-NI for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Aug 2017 00:09:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddqOg-00018C-TU for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 00:09:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddqOc-0000PF-TH for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 00:09:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddqOc-0000P5-OH for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 00:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ddqOc-0006TV-FB for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 00:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2017 04:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27946-submit@debbugs.gnu.org id=B27946.150190610324847 (code B ref 27946); Sat, 05 Aug 2017 04:09:02 +0000 Original-Received: (at 27946) by debbugs.gnu.org; 5 Aug 2017 04:08:23 +0000 Original-Received: from localhost ([127.0.0.1]:42333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddqNz-0006Sh-9v for submit@debbugs.gnu.org; Sat, 05 Aug 2017 00:08:23 -0400 Original-Received: from mail-pg0-f54.google.com ([74.125.83.54]:36855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddqNy-0006SV-HX for 27946@debbugs.gnu.org; Sat, 05 Aug 2017 00:08:22 -0400 Original-Received: by mail-pg0-f54.google.com with SMTP id v77so14720875pgb.3 for <27946@debbugs.gnu.org>; Fri, 04 Aug 2017 21:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-transfer-encoding; bh=jubcaovM/VSMsgn80BogypOze2tIdkShL5DUz1YHiaY=; b=eC3D/enhgZ1J7j10PSrW5u9nH+7i+uEkhlIAdkahI0HKrIYgByuJBpwNc2BTM/xCTA xNYyd/n0In3RXn4auhpjN/WeFkHEKGW5pswBvtDvXCZt8RemebLKtCFcI6SAc6t957Va S8RRnhrjcu//rw3ps2W2nnO2P+I/78sOid3UVAH9UDxrxmeZzsdFZSv39669whZgDYRm Hn4Z4S73+f9oE8YfkVmuuUXyGDV2yi3qPAH66veHkdRXSe40hCm0o9he1d2Y5xUgdxvD 1CPiexetMzlV47dtkFgsvO2JRpl9NxJFfPtK4bq7jvBTjGmPBuPyg5RVo1IoBWpkM1Lv kPiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jubcaovM/VSMsgn80BogypOze2tIdkShL5DUz1YHiaY=; b=HLSAQrrP3jVX8a3vWyG5ddvh9H9fp7tmz8Dg/PwWdPDskmDyY//g8pr4H7/99QK14S enPHqQJZDKiHnV8wJZMusXQw3vhMxS/ans4T7HxHchxxW5uQtwGhnkw7rPp2w8z1kZ0b KMXlNNfVMAayqlQu1UpHtSoPdoim7hWlPa9lf3ExI3C5qXqmQEo2x0drly4jC07T67Gd 8+xXq+jPfBU3wf9HR1CmBlv/9FCaF+nIy5bVUKSFtl3Tgix0dvFRv/Qs+JSm1PbMGavF u70bGYs2avnTdA9cFHUM1Ci7VM+fnG/XScijH1G6BjoTGbzbnzkqIvOhfRcikh+PamSL BrhA== X-Gm-Message-State: AIVw111L2KjHZWt4r8iJkN6UtMTZGUyD5xnHTtFFikXfIDdd+/Gft3FO tIrZmwvJ/xXtHg== X-Received: by 10.98.211.197 with SMTP id z66mr4806430pfk.160.1501906096709; Fri, 04 Aug 2017 21:08:16 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id b29sm505843pfh.22.2017.08.04.21.08.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Aug 2017 21:08:16 -0700 (PDT) In-Reply-To: (Philipp Stephani's message of "Fri, 04 Aug 2017 13:31:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135377 Archived-At: Philipp Stephani writes: > It appears that commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks > the build on Ubuntu 14.04: > > sysdep.c: In function =E2=80=98renameat_noreplace=E2=80=99: > sysdep.c:2695:58: error: =E2=80=98RENAME_NOREPLACE=E2=80=99 undeclared (f= irst use in this function) > return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLAC= E); > > Probably the #ifdef there should also include RENAME_NOREPLACE. I confirm i can build in Ubuntu-14.04 with this patch: diff --git a/src/sysdep.c b/src/sysdep.c index 22446b25d1..9eb733221e 100644 --- a/src/sysdep.c +++ b/src/sysdep.c @@ -2691,7 +2691,7 @@ set_file_times (int fd, const char *filename, int renameat_noreplace (int srcfd, char const *src, int dstfd, char const *dst) { -#ifdef SYS_renameat2 +#if defined SYS_renameat2 && defined RENAME_NOREPLACE return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE); #else errno =3D ENOSYS;