unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: 27946@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04
Date: Sat, 05 Aug 2017 13:08:11 +0900	[thread overview]
Message-ID: <87fud6ejx0.fsf@calancha-pc> (raw)
In-Reply-To: <wvr4efsr1sed.fsf@a.muc.corp.google.com> (Philipp Stephani's message of "Fri, 04 Aug 2017 13:31:06 +0200")

Philipp Stephani <p.stephani2@gmail.com> writes:

> It appears that commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks
> the build on Ubuntu 14.04:
>
> sysdep.c: In function ‘renameat_noreplace’:
> sysdep.c:2695:58: error: ‘RENAME_NOREPLACE’ undeclared (first use in this function)
>    return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);
>
> Probably the #ifdef there should also include RENAME_NOREPLACE.
I confirm i can build in Ubuntu-14.04 with this patch:

diff --git a/src/sysdep.c b/src/sysdep.c
index 22446b25d1..9eb733221e 100644
--- a/src/sysdep.c
+++ b/src/sysdep.c
@@ -2691,7 +2691,7 @@ set_file_times (int fd, const char *filename,
 int
 renameat_noreplace (int srcfd, char const *src, int dstfd, char const *dst)
 {
-#ifdef SYS_renameat2
+#if defined SYS_renameat2 && defined RENAME_NOREPLACE
   return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);
 #else
   errno = ENOSYS;





  reply	other threads:[~2017-08-05  4:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04 11:31 bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04 Philipp Stephani
2017-08-05  4:08 ` Tino Calancha [this message]
2017-08-05  5:36   ` Paul Eggert
2017-08-05  6:50     ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fud6ejx0.fsf@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=27946@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).