From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Daniel Kraus <daniel@kraus.my>, 18951@debbugs.gnu.org
Subject: bug#18951: eshell-pcomplete removes asterisk when attempting completion
Date: Sun, 05 Nov 2017 12:17:27 -0500 [thread overview]
Message-ID: <87fu9s7ihk.fsf@users.sourceforge.net> (raw)
In-Reply-To: <a6f35f27-852b-5f4b-a2f1-13ecd0a43e1c@yandex.ru> (Dmitry Gutov's message of "Fri, 3 Nov 2017 23:25:34 +0200")
tags 18951 fixed
close 18951 26.1
quit
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 11/2/17 4:15 PM, Daniel Kraus wrote:
>>> --- i/lisp/pcomplete.el
>>> +++ w/lisp/pcomplete.el
>>> @@ -772,7 +772,7 @@ pcomplete-parse-arguments
>>> (setq c (cdr c)))
>>> (setq pcomplete-stub (substring common-stub 0 len)
>>> pcomplete-autolist t)
>>> - (when (and begin (not pcomplete-show-list))
>>> + (when (and begin (> len 0) (not pcomplete-show-list))
>>> (delete-region begin (point))
>>> (pcomplete-insert-entry "" pcomplete-stub))
>>> (throw 'pcomplete-completions completions))
>>
>> I didn't test it too much if something else breaks but it
>> seems to work. pcomplete doesn't remove the * and company
>> mode also seems to work without problems now.
>
> Looking good in my testing, and fixes the problem. Thanks!
> pcomplete-completion-at-point is still buggy, of course, but no worse
> than before.
Okay, pushed to emacs-26.
[1: 5d744e032f]: 2017-11-05 11:36:20 -0500
Don't replace user input when completion prefix is empty (Bug#18951)
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5d744e032fee9ce60446a3cc0cf7c2e681ace465>
prev parent reply other threads:[~2017-11-05 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 5:50 bug#18951: 24.4.51; eshell-pcomplete removes asterisk when attempting completion Dmitry Gutov
2017-11-01 4:16 ` bug#18951: " Daniel Kraus
2017-11-01 12:46 ` Noam Postavsky
2017-11-02 7:00 ` Daniel Kraus
2017-11-02 11:32 ` Noam Postavsky
2017-11-02 14:15 ` Daniel Kraus
2017-11-03 21:25 ` Dmitry Gutov
2017-11-05 17:17 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu9s7ihk.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=18951@debbugs.gnu.org \
--cc=daniel@kraus.my \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).