From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31498: [PATCH] Notify systemd in daemon-initialized and kill-emacs Date: Sat, 09 Jun 2018 08:36:02 -0400 Message-ID: <87fu1w16j1.fsf@gmail.com> References: <20180518174031.12514-1-mail@lucaswerkmeister.de> <20180609105616.12927-1-mail@lucaswerkmeister.de> <87k1r816u5.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528547707 22788 195.159.176.226 (9 Jun 2018 12:35:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Jun 2018 12:35:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31498@debbugs.gnu.org To: Lucas Werkmeister Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 09 14:35:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRd5C-0005pB-RT for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 14:35:02 +0200 Original-Received: from localhost ([::1]:40257 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRd7J-0008A5-UB for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 08:37:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRd7D-00089z-NV for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 08:37:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRd78-0002ZQ-L4 for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 08:37:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60760) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRd78-0002Z8-GP for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 08:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRd78-0003SA-3q for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 08:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jun 2018 12:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31498 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31498-submit@debbugs.gnu.org id=B31498.152854777113209 (code B ref 31498); Sat, 09 Jun 2018 12:37:02 +0000 Original-Received: (at 31498) by debbugs.gnu.org; 9 Jun 2018 12:36:11 +0000 Original-Received: from localhost ([127.0.0.1]:40424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRd6I-0003Qy-Ma for submit@debbugs.gnu.org; Sat, 09 Jun 2018 08:36:10 -0400 Original-Received: from mail-it0-f46.google.com ([209.85.214.46]:55536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRd6H-0003Qf-JK for 31498@debbugs.gnu.org; Sat, 09 Jun 2018 08:36:09 -0400 Original-Received: by mail-it0-f46.google.com with SMTP id 16-v6so770916itl.5 for <31498@debbugs.gnu.org>; Sat, 09 Jun 2018 05:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mvInNKu9YcRbprZ10iFBw3UQXfvdZ+iHhVKc4iXa1Wc=; b=rBF68gzKiFSpTNFwYTa2oXZoaMDjOPMGBMybq7by7Ow+CN/NIhTD91kh6uHvguoOZe Ipjk9QD6urkZN6RPgAW0qkFWKLNm/8Ae/JIZigQUpyRoMBTnAMqV6YHvjA+YPSafznDK vtqrE2/O1eHb/yjzprkLhwSE3Qc9jpjr9yPUGaQCYzCF0v9YlyR3kx8ysXtOh72Skryd ZxlhHJYLEVgkoi6oTRqL5v2etw3tWimbyl82WycLEgPxRnBbsu7+RuJgl6vo+M5SgR7v ih6HZZoXYf22ePAPuk0kzUmPcqqY0DXXuVpdXjMSGONvoZokG8lc8HoXPudPtZ7fYioB zt9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mvInNKu9YcRbprZ10iFBw3UQXfvdZ+iHhVKc4iXa1Wc=; b=r//16vduDa6SEEE0nOvRM1IFm397yHn3UWO4OCZupm0X718RcKgb9JOKn2oavV5eZZ xRIjk/fxhSbaM674lTwq4GzEm13OS61iiTz/ftovKQfNhw0gJ/AGRstIL2Ny3BWpGa5y A10uqz0PzK/zmVbu/mJmKspBR0F41aE0NTkKiNRhpFD4PgDrzKUsW1BOXlMIOtwAP0re GrGEAkFpOSRUU85TfpnTP29rGYmurQRcdEhba0OXSizeERODKSgvT0p/MNZzXdj68Xhi HzQq+XUj0CMR9pfU9G1ZGOBo3wjDu8vdsE9QzpoFXcZahefhFt+vKiHuus4S7dLS7t5X ckMQ== X-Gm-Message-State: APt69E1mwchbqYRI1vsrEzjLrFsE48zkbNpYfAejuSEhXLTNKcL0zP+D eTwW8wroWJ1rmITdwt1TF+HjKg== X-Google-Smtp-Source: ADUXVKKp9qgMBzqhMReO4wN+s7awhyJJ+TSZn6PPRBuAXOoNyX/100+yP1FRvtGSTylRA/YMlbNPtA== X-Received: by 2002:a24:82c2:: with SMTP id t185-v6mr5434304itd.117.1528547764018; Sat, 09 Jun 2018 05:36:04 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g26-v6sm2939794iti.0.2018.06.09.05.36.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 05:36:03 -0700 (PDT) In-Reply-To: <87k1r816u5.fsf@gmail.com> (Noam Postavsky's message of "Sat, 09 Jun 2018 08:29:22 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147240 Archived-At: Noam Postavsky writes: > Lucas Werkmeister writes: > >> * etc/emacs.service: Update Type. >> * src/emacs.c (daemon-initialized): Call sd_notify(). >> * src/emacs.c (kill-emacs): Call sd_notify(). Oops, hit send too early. I wanted to add, that you don't need to repeat the same message for the last two ChangeLog entries, and you should use the "Conditional Changes" syntax [1], like so: * src/emacs.c (daemon-initialized) [HAVE_LIBSYSTEMD]: * src/emacs.c (kill-emacs) [HAVE_LIBSYSTEMD]: Call sd_notify(). [1]: https://www.gnu.org/prep/standards/html_node/Conditional-Changes.html PS I was wrong about 'git send-email' being just as good as replying with attachment. The bug tracker adds a "bug#xxxxx:" prefix, so I end up getting duplicate emails. Next time someone asks I'll know what to answer :)