From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#32173: 26.1; wdired: broken 'wdired-use-interactive-rename' Date: Sun, 29 Jul 2018 01:21:25 +0200 Message-ID: <87fu0354lm.fsf@gmx.net> References: <87zhyrfgxu.fsf@delenn.bigo.ensc.de> <83pnzhzo80.fsf@gnu.org> <874lgs984m.fsf@gmx.net> <83va98yero.fsf@gnu.org> <878t64p3az.fsf@gmx.net> <83va91rw7u.fsf@gnu.org> <87zhycmto5.fsf@gmx.net> <8336w4s8d4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532820012 32227 195.159.176.226 (28 Jul 2018 23:20:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jul 2018 23:20:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 32173@debbugs.gnu.org, enrico.scholz@ensc.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 29 01:20:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYVK-0008Fx-Ut for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jul 2018 01:20:07 +0200 Original-Received: from localhost ([::1]:46655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjYXQ-0004D2-1L for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jul 2018 19:22:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjYXF-0004Cp-U9 for bug-gnu-emacs@gnu.org; Sat, 28 Jul 2018 19:22:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjYXC-0007Lv-Px for bug-gnu-emacs@gnu.org; Sat, 28 Jul 2018 19:22:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjYXC-0007Lf-ME for bug-gnu-emacs@gnu.org; Sat, 28 Jul 2018 19:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fjYXC-0003s7-GF for bug-gnu-emacs@gnu.org; Sat, 28 Jul 2018 19:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jul 2018 23:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32173 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32173-submit@debbugs.gnu.org id=B32173.153282009614828 (code B ref 32173); Sat, 28 Jul 2018 23:22:02 +0000 Original-Received: (at 32173) by debbugs.gnu.org; 28 Jul 2018 23:21:36 +0000 Original-Received: from localhost ([127.0.0.1]:33150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYWm-0003r6-Dn for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:36 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:60615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYWk-0003qt-GP for 32173@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:35 -0400 Original-Received: from rosalinde ([188.109.196.87]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MXqV1-1fVxq42liZ-00Wmu4; Sun, 29 Jul 2018 01:21:27 +0200 In-Reply-To: <8336w4s8d4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 27 Jul 2018 23:59:19 +0300") X-Provags-ID: V03:K1:0MhY1CrkhWvzdU+hzYSTCvrOjaCU34Q1nS7aBYTVg0wa/R+lJum mLGFhBYENDOzNA5CdLjKEbLi686oOMhhX3wNtrl7zMb5xfMbCWWocFi/ETqVmQWUb8DPN5u Mj0insjgIK51PSGvWJxnONS19MWnpWfgeNzZKs4KGxiKoDOyZ08xtsQOEd9EXr5cizh4lsj zCTEffyMEq++FI73GPjTQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:8vPFmSZBs3M=:n+Km1fYJZ5oi1RktF+m0KS 9kiHmFNtIWVc7MxYsswG32msliQg0cW4dpfv3AL2m5n+VrLyXdBCYYcTzFl0tHAxUcRMZBQSB s9p488i6r9YnMRbt/11TTk1gwPsu5Vw1JBy6VAPfREH13xNuH/41dLESUlXeMtHQP90Y4n0zS 1U2EZC/RaIlEhYhUFdgtJCG9JC4AMm43pEkwm5rAMXYIUUtzXpAYp/Xw6Yj9s4jJChJ6NJlAT kxcv26KwSJER7lLPPuT76gOOsWFwHvD6EPUyjL6XNB4HcSJjPjKkteqf1py7ZOm9dlkCvxwY/ FmI0InabkRX89tXeYfffAtVvvDp0C3rw6gK1zw4DYnbDvQSedHzmpBI1x0g1D8x4el7O2iEGR +8XBk8ZgUnm0PAkVZCFBy0lImHkqUPCiqvrKTtK8QLbwsQJyem+BcWgC8Iv+lHP9eVyOqc3nf Ale6oun4343CVDOeC9n9Xj8HIphLaMGLY8+k3lMYXUkcc0hoKWi6ui13APU7tjDvzKz9byroU 9Q9kqrKg84VG4NbKNgrUP25Y672qGwPJWQ6TtmdpJbMW03oQVb8lCY+KslHakVM0v52I7jD2B LC6s6AEXCcKyXcyZuOUGppIGPIfmih6j4KH6JIBF0prlmmrVSd7Vpimvy/6mwilg1s9ge0Dro szt3KKXdNUVo4Q58IhGRL44HXyte/mwiG02yuDeGX9kwTGQE3Daa/lDQtvqiDwJ5soXie7Aho jWrbyG+jTFvdM8t3/8tCPFy5WSyXM60MScQGCTtq67huZt4Gl7mR6sEhdp5Z9FbfFJ+QkW5S X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149043 Archived-At: On Fri, 27 Jul 2018 23:59:19 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: enrico.scholz@ensc.de, 32173@debbugs.gnu.org >> Date: Fri, 27 Jul 2018 20:15:38 +0200 >> >> > Thanks. I think we should install your original and safer patch on >> > the release branch, and this more thorough fix on master. WDYT? >> >> Sounds reasonable. Should we give the OP a bit longer to react or >> should I just go ahead and commit the fixes (in any case, I may not be >> able to until tomorrow or Sunday)? > > I think by then we will have waited long enough. > >> I also wrote three tests, two for the bug with non-nil >> wdired-use-interactive-rename, one where the edit is finished and one >> where it's aborted, and one test for unfinished edits (it might be nice >> to have a variant of the latter that uses dired-isearch-filenames, but I >> don't see any straightforward way to emulate isearch in the test >> environment). The first two tests are suitable for both fixes, but the >> third test only succeeds with the fix intended for master, so I use the >> :expected-result keyword in the test definition. But should I install >> the test file on each branch as part of the commit with the respective >> fix (which won't be merged from release to master), or should I make a >> separate commit of the test file just to the release branch and let it >> be merged to master? > > You can commit the tests to the emacs-26 branch and let it be merged. > > Thanks. I committed the fixes and the tests. I'll wait another couple of days to see if the OP responds, and then close the bug. Steve Berman