unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 32452@debbugs.gnu.org
Subject: bug#32452: 26.1; gnutls_try_handshake maxes out cpu retrying when server is a bit busy
Date: Fri, 17 Aug 2018 18:10:32 -0400	[thread overview]
Message-ID: <87ftzcwso7.fsf@gmail.com> (raw)
In-Reply-To: <83d0uhgoxw.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Aug 2018 15:25:31 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> In which case it's fine, we just need to do something in the loop to
> yield the CPU, like some nanosleep, perhaps?  And maybe enlarge the
> sleep period as time goes on?
>
> debbugs is terribly slow in a browser as well, right now.  But
> hundreds of attempts sounds excessive to me.

The debbugs server seems back to normal speeds now, I'm getting ~200
hits with it just like other servers.  The patch below brings it down to
15~20.  nanosleep isn't portable though right?  Not sure what to put
instead, it seems existing wait functions in Emacs are all tied up with
threads and processes, so I don't know if it's safe to call them here.

--- i/src/gnutls.c
+++ w/src/gnutls.c
@@ -550,6 +550,8 @@ gnutls_try_handshake (struct Lisp_Process *proc)
   if (non_blocking)
     proc->gnutls_p = true;
 
+  enum { MAX_DELAY_NS = 100 * 1000 * 1000 }; // Max 100ms delay.
+  struct timespec delay = { 0, 1000 };
   do
     {
       ret = gnutls_handshake (state);
@@ -558,7 +560,9 @@ gnutls_try_handshake (struct Lisp_Process *proc)
     }
   while (ret < 0
 	 && gnutls_error_is_fatal (ret) == 0
-	 && ! non_blocking);
+	 && ! non_blocking
+         && (nanosleep (&delay, NULL),
+             delay.tv_nsec = min (delay.tv_nsec * 2, MAX_DELAY_NS)));
 
   proc->gnutls_initstage = GNUTLS_STAGE_HANDSHAKE_TRIED;






  reply	other threads:[~2018-08-17 22:10 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16 12:13 bug#32452: 26.1; gnutls_try_handshake maxes out cpu retrying when server is a bit busy Noam Postavsky
2018-08-16 12:49 ` Noam Postavsky
2018-08-16 13:41 ` Eli Zaretskii
2018-08-16 14:45   ` Noam Postavsky
2018-08-16 17:33     ` Eli Zaretskii
2018-08-17  1:02       ` Noam Postavsky
2018-08-17  5:59         ` Eli Zaretskii
2018-08-17 11:55           ` Noam Postavsky
2018-08-17 12:25             ` Eli Zaretskii
2018-08-17 22:10               ` Noam Postavsky [this message]
2018-08-18  6:34                 ` Eli Zaretskii
2018-08-21  0:52                   ` Noam Postavsky
2018-08-21  2:42                     ` Eli Zaretskii
2022-02-21 15:20                       ` Lars Ingebrigtsen
2022-02-23 19:45                         ` Paul Eggert
2022-02-23 19:48                           ` Lars Ingebrigtsen
2022-02-23 22:29                             ` Paul Eggert
2022-02-23 22:40                               ` Lars Ingebrigtsen
2022-02-24  3:09                                 ` Paul Eggert
2022-02-24  8:57                                   ` Lars Ingebrigtsen
2022-02-24 18:20                                     ` Paul Eggert
2022-02-25  2:19                                       ` Lars Ingebrigtsen
2022-02-25  2:27                                       ` Lars Ingebrigtsen
2022-02-25 20:41                                         ` Paul Eggert
     [not found]                                         ` <6f364184-7fa8-04f3-44a9-22ce40b872e8@cs.ucla.edu>
2022-02-26 15:12                                           ` Lars Ingebrigtsen
2022-02-26 15:37                                             ` Eli Zaretskii
     [not found]                                             ` <83ee3pprkr.fsf@gnu.org>
2022-02-26 16:04                                               ` Lars Ingebrigtsen
     [not found]                                               ` <87pmn9txzo.fsf@gnus.org>
2022-02-28  8:59                                                 ` Lars Ingebrigtsen
     [not found]                                                 ` <87ee3ns6x0.fsf@gnus.org>
2022-02-28 12:28                                                   ` Eli Zaretskii
     [not found]                                                   ` <83y21vmaye.fsf@gnu.org>
2022-02-28 12:31                                                     ` Lars Ingebrigtsen
2022-02-28 12:35                                                       ` Lars Ingebrigtsen
     [not found]                                                       ` <877d9fnp7g.fsf@gnus.org>
2022-02-28 12:46                                                         ` Eli Zaretskii
2022-02-28 21:47                                                   ` Paul Eggert
     [not found]                                                   ` <78c5037a-ac96-e7be-532f-b1776ed25b2b@cs.ucla.edu>
2022-03-01 15:36                                                     ` Lars Ingebrigtsen
     [not found]                                                     ` <87a6e9n0rg.fsf@gnus.org>
2022-03-01 18:27                                                       ` Paul Eggert
     [not found]                                                       ` <d0cfd485-2be6-5873-64dc-2926c2f2bae0@cs.ucla.edu>
2022-03-01 18:52                                                         ` Lars Ingebrigtsen
     [not found]                                                         ` <87czj5ld38.fsf@gnus.org>
2022-03-02  1:00                                                           ` Paul Eggert
     [not found]                                                           ` <d24b1278-1aeb-e17d-ed06-7d36c5e3b68b@cs.ucla.edu>
2022-03-02  1:22                                                             ` Lars Ingebrigtsen
2022-03-02  1:43                                                               ` Lars Ingebrigtsen
     [not found]                                                             ` <87y21tjggy.fsf@gnus.org>
2022-03-02  2:12                                                               ` Paul Eggert
     [not found]                                                               ` <ab47871e-ad1e-e06d-c226-ab7b7c9bb857@cs.ucla.edu>
2022-03-03 13:46                                                                 ` Lars Ingebrigtsen
2022-03-03 13:49                                                                 ` Lars Ingebrigtsen
     [not found]                                                                 ` <87czj3jgdd.fsf@gnus.org>
2022-03-03 15:11                                                                   ` Eli Zaretskii
2022-03-04 15:28                                                                     ` Lars Ingebrigtsen
2022-03-04 16:47                                                                       ` Lars Ingebrigtsen
2022-03-04 19:46                                                                         ` Eli Zaretskii
2022-03-05 17:11                                                                           ` Lars Ingebrigtsen
2022-03-05 17:47                                                                             ` Eli Zaretskii
2022-03-05 18:06                                                                               ` Lars Ingebrigtsen
2022-03-09  3:01                                                                             ` Paul Eggert
     [not found]                                                                 ` <87h78fjgi7.fsf@gnus.org>
2022-03-03 21:40                                                                   ` Paul Eggert
     [not found]                                                                   ` <0756f1bd-1348-84ef-4eb8-4cc25eacf1dd@cs.ucla.edu>
2022-03-04 15:31                                                                     ` Lars Ingebrigtsen
2019-09-24  5:39                 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftzcwso7.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=32452@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).