unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#32683: 26.1.50; multi-occur-in-matching-buffers defaults could be improved
@ 2018-09-10 14:48 Tom Tromey
  2019-07-13  2:37 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2018-09-10 14:48 UTC (permalink / raw)
  To: 32683


I tried M-x multi-occur-in-matching-buffers.

First, it does not provide a default for the file name regexp.
I think it would be nice if it used the same logic as M-x rgrep.

Second, it uses the file name regexp as the default search regexp.
This is not a very good default.  Again, following rgrep and using the
word under point would be better.

Finally, multi-occur-in-matching-buffers asks for the file name regexp
first and the search regexp second; whereas rgrep and lrgrep do this in
the other order.  I think it would be nice if they were all consistent.

Tom



In GNU Emacs 26.1.50 (build 11, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
 of 2018-09-06 built on pokyo
Repository revision: 6c616e465cc83cf376d4df75f9c4afdbdf0ef6ca
Windowing system distributor 'Fedora Project', version 11.0.11906000
System Description:	Fedora release 28 (Twenty Eight)

Recent messages:
 
No more unseen articles
Quit
Are you sure you want to quit reading news? (y or n) y
Saving /home/tromey/.newsrc.eld...
Saving file /home/tromey/.newsrc.eld...
Wrote /home/tromey/.newsrc.eld
Saving /home/tromey/.newsrc.eld...done
Scanning for dabbrevs...done
user-error: No dynamic expansion for ‘multi-occur-’ found
Quit [2 times]
Configured using:
 'configure --prefix=/home/tromey/Emacs/install --with-modules'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS GLIB NOTIFY
LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Rust

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  ggtags-mode: t
  bug-reference-prog-mode: t
  diff-auto-refine-mode: t
  flyspell-mode: t
  shell-dirtrack-mode: t
  which-function-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-notify-mode: t
  erc-notifications-mode: t
  erc-match-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-hl-nicks-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  savehist-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  auto-fill-function: rust-do-auto-fill
  transient-mark-mode: t

Load-path shadows:
/home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/26.1.50/lisp/play/bubbles

Features:
(shadow emacsbug org-rmail org-mhe org-irc org-info org-gnus org-docview
doc-view image-mode org-bibtex bibtex org-bbdb org-w3m org-element
avl-tree generator org org-macro org-footnote org-pcomplete org-list
org-faces org-entities org-version ob-emacs-lisp ob ob-tangle org-src
ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval
org-compat org-macs org-loaddefs compare-w markdown-mode noutline
outline css-mode sgml-mode eww time-stamp cl-print two-column iso-transl
pulse find-file idutils tabify man texinfo tcl goto-addr make-mode
log-edit edebug eglot jsonrpc flymake-proc flymake array ert debug
autoload lisp-mnt cus-edit kmacro tar-mode jka-compr mailalias gud
bbdb-sc supercite regi mail-hist nnir url-http url-auth url-gw sh-script
smie executable pcase flow-fill log-view pcvs-util gnus-html url-queue
help-fns radix-tree url-cache mm-url url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf whitespace
cc-mode cc-fonts cc-guess cc-menus cc-cmds term/xterm xterm ffap
conf-mode dabbrev dwarf-mode llvm-mode copyright find-dired wgrep grep
bbdb-gui bbdb-hooks bbdb-rmail rmailsum sort gnus-cite smiley shr-color
shr svg dom browse-url mm-archive gnus-bcklg gnus-async qp gnus-ml
disp-table misearch multi-isearch vc-mtn vc-hg gnus-topic nndraft nnmh
nnfolder utf-7 bbdb-gnus bbdb-snarf mail-extr bbdb-com gnus-agent
gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu
mml2015 mm-view mml-smime smime dig mailcap nntp gnus-cache gnus-sum
gnus-group gnus-undo smtpmail sendmail gnus-start gnus-cloud nnimap
nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range message
rfc822 mml mml-sec epa derived epg mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win gnus
nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums
mail-utils mm-util mail-prsvr network-stream puny nsm rmc starttls tls
gnutls erc-list erc-menu erc-join erc-ring erc-pcomplete erc-netsplit
erc-spelling erc-truncate vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs
add-log ggtags etags xref project compile bug-reference vc-git diff-mode
rust-mode elec-pair flyspell ispell diminish appt diary-lib
diary-loaddefs cal-menu calendar cal-loaddefs tramp tramp-compat
tramp-loaddefs trampver ucs-normalize shell pcomplete parse-time
which-func imenu autorevert filenotify desktop frameset cus-start
cus-load git-link url-util erc-track erc-notify
erc-desktop-notifications erc-match erc-services erc-networks
notifications dbus xml erc-hl-nicks easy-mmode color erc-button erc-fill
erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec
thingatpt pp dired-aux dired-x dired dired-loaddefs warnings advice
vc-dir ewoc vc vc-dispatcher flycheck cl-extra json map find-func
help-mode rx subr-x dash cc-styles cc-align cc-engine cc-vars cc-defs
bbdb cl timezone ange-ftp comint ansi-color ring server savehist
finder-inf bbdb-autoloads lisppaste-autoloads pydoc-info-autoloads
info-look info package easymenu epg-config url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv
cl-loaddefs cl-lib time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 1566689 319029)
 (symbols 48 118943 290)
 (miscs 40 34346 6714)
 (strings 32 426988 38136)
 (string-bytes 1 10187104)
 (vectors 16 155415)
 (vector-slots 8 2826717 136632)
 (floats 8 638 1299)
 (intervals 56 82125 11171)
 (buffers 992 213))





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#32683: 26.1.50; multi-occur-in-matching-buffers defaults could be improved
  2018-09-10 14:48 bug#32683: 26.1.50; multi-occur-in-matching-buffers defaults could be improved Tom Tromey
@ 2019-07-13  2:37 ` Lars Ingebrigtsen
  2019-07-13  2:46   ` Tom Tromey
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-13  2:37 UTC (permalink / raw)
  To: Tom Tromey; +Cc: 32683

Tom Tromey <tom@tromey.com> writes:

> First, it does not provide a default for the file name regexp.
> I think it would be nice if it used the same logic as M-x rgrep.
>
> Second, it uses the file name regexp as the default search regexp.
> This is not a very good default.  Again, following rgrep and using the
> word under point would be better.

Yes, the rgrep defaults seem more intuitive...  but
multi-occur-in-matching-buffers is part of the "Occur" framework and
works more like those functions. 

> Finally, multi-occur-in-matching-buffers asks for the file name regexp
> first and the search regexp second; whereas rgrep and lrgrep do this in
> the other order.  I think it would be nice if they were all consistent.

It would, but I don't think this is possible at this date -- the command
in question is at least a decade old.  So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#32683: 26.1.50; multi-occur-in-matching-buffers defaults could be improved
  2019-07-13  2:37 ` Lars Ingebrigtsen
@ 2019-07-13  2:46   ` Tom Tromey
  2019-07-13 13:56     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2019-07-13  2:46 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Tom Tromey, 32683

Lars> It would, but I don't think this is possible at this date -- the command
Lars> in question is at least a decade old.  So I'm closing this bug report.

How about adding a new command that works better?

Tom





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#32683: 26.1.50; multi-occur-in-matching-buffers defaults could be improved
  2019-07-13  2:46   ` Tom Tromey
@ 2019-07-13 13:56     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-13 13:56 UTC (permalink / raw)
  To: Tom Tromey; +Cc: 32683

Tom Tromey <tom@tromey.com> writes:

> Lars> It would, but I don't think this is possible at this date -- the command
> Lars> in question is at least a decade old.  So I'm closing this bug report.
>
> How about adding a new command that works better?

My feeling is that rgrep has us pretty much covered -- this occur
command isn't really that vital...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-13 13:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-10 14:48 bug#32683: 26.1.50; multi-occur-in-matching-buffers defaults could be improved Tom Tromey
2019-07-13  2:37 ` Lars Ingebrigtsen
2019-07-13  2:46   ` Tom Tromey
2019-07-13 13:56     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).