From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32731: 26.1.50; Ibuffer filter by mode: Handle >1 mode names Date: Thu, 13 Sep 2018 19:39:17 -0400 Message-ID: <87ftydezmi.fsf@gmail.com> References: <87bm919s5y.fsf@calancha-pc.dy.bbexcite.jp> <874let9lps.fsf@calancha-pc.dy.bbexcite.jp> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536881907 23747 195.159.176.226 (13 Sep 2018 23:38:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Sep 2018 23:38:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32731@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 14 01:38:23 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0bBn-00066S-9z for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Sep 2018 01:38:23 +0200 Original-Received: from localhost ([::1]:46638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0bDt-00034i-HU for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Sep 2018 19:40:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0bDi-00034Z-5a for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:40:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0bDX-0008I2-F4 for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:40:16 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g0bDO-00089a-Fi for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:40:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g0bDO-0002cJ-8X for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 19:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Sep 2018 23:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32731-submit@debbugs.gnu.org id=B32731.153688196710010 (code B ref 32731); Thu, 13 Sep 2018 23:40:02 +0000 Original-Received: (at 32731) by debbugs.gnu.org; 13 Sep 2018 23:39:27 +0000 Original-Received: from localhost ([127.0.0.1]:39804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0bCo-0002bO-Oj for submit@debbugs.gnu.org; Thu, 13 Sep 2018 19:39:26 -0400 Original-Received: from mail-it0-f46.google.com ([209.85.214.46]:40205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0bCn-0002b9-Cm for 32731@debbugs.gnu.org; Thu, 13 Sep 2018 19:39:25 -0400 Original-Received: by mail-it0-f46.google.com with SMTP id h23-v6so290691ita.5 for <32731@debbugs.gnu.org>; Thu, 13 Sep 2018 16:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5SjIPA0+ZJk86zkOd5q8S7tm2fqHL5pnuD9aA8LzzKI=; b=gqFPGlohY1USQ75YuWnXJEJ7qWdUaGdByHniFChsbthaiqbme44z28rdYhhNjwmZxW u8NmNqRcWeKJdNnmv44qca27+M7pYJ5jayxOr0ljhKReCt+Qlo+UnM8SVijJkQEe7r7a +szCJtJj+GxW+Dy1hfXf2yuiNx6lAs9E7z567oFPDubCFee32s7YnZXpkSD996r3s7CU yalqx6Ll2SZT1v0orcTqkxnHX+GwhX4A0XEBWi4OzG2pAZOzJBdg0UrXy51dz4H5Ow3S 9d8zaZhcguPwRnlnKGNcBm5I7NNbYffDxWo9r8Ol5unZUZyPjPUB83EwiaX3UWmcbZTK sQ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5SjIPA0+ZJk86zkOd5q8S7tm2fqHL5pnuD9aA8LzzKI=; b=mkwt1hiscNN9RCOuE9M39XtI9XV28LBLEoB/ehcPEin7ZVNUlBuDspyk4cFftWr5zr ARR8iQePdl9eYdYfKeiijV1XRiTGHlcFskeKm9x1llZUMTvaWfWSQNCFxFeyhxsUXNf1 6eP/PISdElpx0F+wKAbwTI5XOdFHmHdLFHSHK4VpYrX7jRClDIGqrMK71w9yUCFRznN6 0hO4WXfSdZBpgjby0uFdUE3mjbicwayF9ep3nsAlsj3SyM+gk1VP2t+CodT1oThb2pwx 1ujqJMuV05+Nr2D0l5aj66LpNxHG6JwIUcKOJSFeZ06xv8d84cU1RTNsX0wZdwcNVRfP l8Wg== X-Gm-Message-State: APzg51CSyRphYkqu7PGpn4gP3Z1f4bMWtyyj/4aYKhQPkX2OCIXTSI3l MpMusdjdQr3b1bs1bAuxtBiLg5cZ X-Google-Smtp-Source: ANB0Vdamwn8EcTY3o7tMl+5+TyfuD3FhlmgGncQgopGKk0Si8l43RoiWlaNad6tMUVYy/IR2KFt2Ag== X-Received: by 2002:a24:255:: with SMTP id 82-v6mr334601itu.144.1536881959637; Thu, 13 Sep 2018 16:39:19 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u5-v6sm1708006ioc.85.2018.09.13.16.39.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Sep 2018 16:39:18 -0700 (PDT) In-Reply-To: <874let9lps.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Fri, 14 Sep 2018 05:38:39 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150304 Archived-At: Tino Calancha writes: >> Maybe it's simpler to construct the filter directly? As in: >> >> (push `(or ,@(mapcar (lambda (m) `(used-mode . ,m)) modes)) >> ibuffer-filtering-qualifiers) >> (ibuffer-update nil t) > I tried this way and I see 2 nits: > 1) With just one mode you still get superflous `or' > [OR [major mode in use: mode1]] > > 2) Also, with just one mode, we miss the printout message > with the description: > "Filter by major mode in use added: mode1" Yeah, we need special cases for lists of zero and one modes. > Less important but `define-ibuffer-filter' performs some checks > (there is a `condition-case'). The condition-case thing is in a lambda form which goes into ibuffer-filtering-alist, so I don't think there is a need to explicitly invoke it when constructing a filter of an existing type. > Next one just use `completing-read-multiple' (keeps calling > `'ibuffer-filter-by-used-mode'); I prefer this one: I would be okay if it was just a matter of repeated ibuffer-filter-* calls, but the fact that it produces error messages which then need to be hidden makes it unacceptable, IMO.