From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 32672@debbugs.gnu.org
Subject: bug#32672: 27.0.50; image resize on window resizing
Date: Fri, 21 Sep 2018 02:15:45 +0300 [thread overview]
Message-ID: <87fty3sp6a.fsf@mail.linkov.net> (raw)
In-Reply-To: <5BA34D7E.4030509@gmx.at> (martin rudalics's message of "Thu, 20 Sep 2018 09:34:22 +0200")
>> But the problem is that the buffer-local hook will have such idiomatic code:
>>
>> (with-current-buffer (window-buffer window)
>> ...
>
> Where does 'window' come from? At the time 'buffer-list-update-hook'
> gets called, there's no guarantee that the buffer whose local hook
> runs is even shown in a window.
Thank you, now it's possible to finish this feature,
it gets 'window' using get-buffer-window-list:
diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 19fa28d440..3355ee6109 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -574,6 +574,9 @@ image-mode
(add-hook 'change-major-mode-hook 'image-toggle-display-text nil t)
(add-hook 'after-revert-hook 'image-after-revert-hook nil t)
+ (add-hook 'window-size-change-functions (debounce 'image-size-window-change 1) nil t)
+ (add-hook 'buffer-list-update-hook 'image-size-buffer-change nil t)
+
(run-mode-hooks 'image-mode-hook)
(let ((image (image-get-display-property))
(msg1 (substitute-command-keys
@@ -822,6 +826,42 @@ image-after-revert-hook
(get-buffer-window-list (current-buffer) 'nomini 'visible))
(image-toggle-display-image)))
+(defun image-size-window-change (&optional frame)
+ (let (buffers)
+ (walk-windows (lambda (window)
+ (with-current-buffer (window-buffer window)
+ (when (derived-mode-p 'image-mode)
+ (push (current-buffer) buffers))))
+ 'nomini (or frame 'visible))
+ (mapc (lambda (buffer) (image-size-buffer-change buffer))
+ (delq nil (delete-dups buffers)))))
+
+(defun image-size-buffer-change (&optional buffer)
+ (with-current-buffer (or buffer (current-buffer))
+ (when (derived-mode-p 'image-mode)
+ (let* ((spec (image-get-display-property))
+ (spec (and (eq (car-safe spec) 'image) spec))
+ (max-width (plist-get (cdr spec) :max-width))
+ (max-height (plist-get (cdr spec) :max-height))
+ (windows (and (or max-width max-height)
+ (get-buffer-window-list
+ (current-buffer) 'nomini 'visible)))
+ min-width min-height min-window)
+ (mapc (lambda (window)
+ (let* ((edges (window-inside-pixel-edges window))
+ (width (- (nth 2 edges) (nth 0 edges)))
+ (height (- (nth 3 edges) (nth 1 edges))))
+ (setq min-width (if min-width (min min-width width) width))
+ (setq min-height (if min-height (min min-height height) height))
+ (when (and (= min-width width)
+ (= min-height height))
+ (setq min-window window))))
+ windows)
+ (when (or (and min-width max-width (not (= min-width max-width)))
+ (and min-height max-height (not (= min-height max-height))))
+ (with-selected-window min-window
+ (image-toggle-display-image)))))))
+
\f
;;; Animated images
next prev parent reply other threads:[~2018-09-20 23:15 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-09 15:54 bug#32672: 27.0.50; image resize on window resizing Juri Linkov
2018-09-11 23:53 ` Juri Linkov
2018-09-12 6:33 ` martin rudalics
2018-09-12 23:18 ` Juri Linkov
2018-09-13 7:46 ` martin rudalics
2018-09-13 23:20 ` Juri Linkov
2018-09-14 8:33 ` martin rudalics
2018-09-15 23:35 ` Juri Linkov
2018-09-16 9:10 ` martin rudalics
2018-09-16 23:49 ` Juri Linkov
2018-09-17 6:46 ` martin rudalics
2018-09-17 22:35 ` Juri Linkov
2018-09-19 8:22 ` martin rudalics
2018-09-19 23:15 ` Juri Linkov
2018-09-20 7:34 ` martin rudalics
2018-09-20 23:15 ` Juri Linkov [this message]
2018-09-21 6:34 ` martin rudalics
2018-09-22 22:15 ` Juri Linkov
2018-09-23 8:26 ` martin rudalics
2018-09-23 20:39 ` Juri Linkov
2018-09-24 8:22 ` martin rudalics
2018-09-24 8:35 ` Eli Zaretskii
2018-09-24 12:25 ` martin rudalics
2018-09-24 12:46 ` Eli Zaretskii
2018-09-24 17:37 ` martin rudalics
2018-09-24 17:53 ` Eli Zaretskii
2018-09-25 7:26 ` martin rudalics
2018-09-25 9:19 ` Eli Zaretskii
2018-09-25 17:56 ` martin rudalics
2018-09-25 18:31 ` Eli Zaretskii
2018-09-24 18:38 ` Juri Linkov
2018-09-24 19:31 ` Eli Zaretskii
2018-09-25 7:27 ` martin rudalics
2018-09-25 19:24 ` Juri Linkov
2018-09-26 8:51 ` martin rudalics
2018-10-27 19:38 ` Juri Linkov
2018-10-28 8:59 ` martin rudalics
2018-09-24 18:31 ` Juri Linkov
2018-09-25 7:27 ` martin rudalics
2018-12-26 23:42 ` Juri Linkov
2018-12-27 9:36 ` martin rudalics
2018-12-27 21:41 ` Juri Linkov
2018-12-28 8:34 ` martin rudalics
2018-12-27 15:48 ` Eli Zaretskii
2018-12-27 20:58 ` Juri Linkov
2018-12-28 4:51 ` Eli Zaretskii
2019-09-26 13:27 ` Lars Ingebrigtsen
2019-11-27 21:53 ` Juri Linkov
2019-11-28 9:20 ` martin rudalics
2019-11-28 22:50 ` Juri Linkov
2019-11-29 9:24 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fty3sp6a.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=32672@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).