From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#33005: 27.0.50; Data loss with Gnus registry Date: Wed, 10 Oct 2018 16:05:50 -0700 Message-ID: <87ftxdl7w1.fsf@ericabrahamsen.net> References: <871s8yvsrq.fsf@web.de> <87in29x33z.fsf@ericabrahamsen.net> <87r2gxygox.fsf@web.de> <87efcxwzr2.fsf@ericabrahamsen.net> <874ldtlcks.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539212651 22102 195.159.176.226 (10 Oct 2018 23:04:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 10 Oct 2018 23:04:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33005@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 11 01:04:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gANWM-0005XC-Ho for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Oct 2018 01:04:02 +0200 Original-Received: from localhost ([::1]:59514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gANYS-000240-NS for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Oct 2018 19:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gANYM-00023r-D5 for bug-gnu-emacs@gnu.org; Wed, 10 Oct 2018 19:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gANYI-0002Xk-EQ for bug-gnu-emacs@gnu.org; Wed, 10 Oct 2018 19:06:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39703) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gANYI-0002XU-7y for bug-gnu-emacs@gnu.org; Wed, 10 Oct 2018 19:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gANYH-0002PO-So for bug-gnu-emacs@gnu.org; Wed, 10 Oct 2018 19:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Oct 2018 23:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33005 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33005-submit@debbugs.gnu.org id=B33005.15392127539244 (code B ref 33005); Wed, 10 Oct 2018 23:06:01 +0000 Original-Received: (at 33005) by debbugs.gnu.org; 10 Oct 2018 23:05:53 +0000 Original-Received: from localhost ([127.0.0.1]:43961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gANY9-0002P2-7c for submit@debbugs.gnu.org; Wed, 10 Oct 2018 19:05:53 -0400 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:50665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gANY7-0002Ou-TV for 33005@debbugs.gnu.org; Wed, 10 Oct 2018 19:05:52 -0400 Original-Received: from localhost (50-251-205-17-static.hfc.comcastbusiness.net [50.251.205.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 0AFFC3F08D; Wed, 10 Oct 2018 23:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1539212751; bh=sHAfgMHGDI9wPtLffTXmPAPsX2lMmSai2Q9HvrVOPJY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aJx9RboSGbSZ+cEuGNm8fwMCNG49UeA4ddxtQZaqS/i8Y1M36XXcxx6SiMPYeEQqR VzsSQWDUcKWZQcBr7rJMtIFlGZP0p1HxqdugxurGBhRTtU4bKuzhq5LEF0LwjF6RkL V6NE+M525TQdO0sjwjH/C6ghXPkPblD/vQ8mfoDc= In-Reply-To: <874ldtlcks.fsf@web.de> (Michael Heerdegen's message of "Wed, 10 Oct 2018 23:24:35 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151087 Archived-At: On 10/10/18 23:24 PM, Michael Heerdegen wrote: > Eric Abrahamsen writes: > >> (registry-collect-prune-candidates gnus-registry-db >> (registry-size gnus-registry-db) nil) > > Ok, I managed to debug this. > > The entry is indeed pruned. It looks like > > Key: "<153...>" > > Value: ((mark Important) (subject ...) ...) > > In the `registry-collect-prune-candidates' method, the variable PRECIOUS > is bound to the list (gnorb-ids org-tags mark). > > AFAIU, since PRECIOUS-P is defined as > > (lambda (entry-key) (cdr (memq (car-safe entry-key) precious))) > > and the symbol mark comes last in the PRECIOUS list, the `cdr' of the > `memq' call is nil. If I remove the `cdr' call, the entry isn't pruned > any more. I also don't get why that `cdr' is there. Or is my value of > PRECIOUS illegal? Nice work! I have no idea why that `cdr' is in there, and as the value is used as a boolean it seems totally superfluous. I don't use registry marks, which is probably the reason I never noticed (I didn't write this code). I don't see any reason not to remove the `cdr', and will do so unless someone objects cogently, soon. Thanks, Eric