From: "João Távora" <joaotavora@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 33736@debbugs.gnu.org
Subject: bug#33736: flymake test different-diagnostic-types confuses gcc and CC
Date: Fri, 04 Jan 2019 20:21:48 +0000 [thread overview]
Message-ID: <87ftu8jhr7.fsf@gmail.com> (raw)
In-Reply-To: <wzimzv7upa.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 14 Dec 2018 14:51:45 -0500")
Glenn Morris <rgm@gnu.org> writes:
> Glenn Morris wrote:
>
>> flymake-test's different-diagnostic-types is skipped if "gcc" seems too old.
>> However, what matters to the rest of the test is $CC, not gcc.
>
> AFAICS the tests are gcc-specific, so the Makefile should enforce that:
>
> --- i/test/lisp/progmodes/flymake-resources/Makefile
> +++ w/test/lisp/progmodes/flymake-resources/Makefile
> @@ -8,6 +8,6 @@ CC_OPTS = -Wall -Wextra
> ## normally use flymake, so it seems like just avoiding the issue
> ## in this test is fine. Set flymake-log-level to 3 to investigate.
> check-syntax:
> - GCC_COLORS= $(CC) $(CC_OPTS) ${CHK_SOURCES} || true
> + GCC_COLORS= gcc $(CC_OPTS) ${CHK_SOURCES} || true
>
> # eof
Makes sense, thanks.
João
prev parent reply other threads:[~2019-01-04 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 2:35 bug#33736: flymake test different-diagnostic-types confuses gcc and CC Glenn Morris
2018-12-14 19:51 ` Glenn Morris
2019-01-04 20:21 ` João Távora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftu8jhr7.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=33736@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).