From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: 34215@debbugs.gnu.org
Subject: bug#34215: 27.0.50; Provide elisp access to Chinese pinyin-to-character mapping
Date: Sat, 23 Feb 2019 21:36:10 -0800 [thread overview]
Message-ID: <87ftsd3fzp.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <83tvhnyh2z.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 01 Feb 2019 11:48:52 +0200")
On 02/01/19 11:48 AM, Eli Zaretskii wrote:
>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Date: Thu, 31 Jan 2019 11:35:32 -0800
>>
>> +(defun pinyin-convert ()
>> + "Convert text file pinyin.map into an elisp library.
>> +The library is named pinyin.el, and contains the constant
>> +`pinyin-character-map'."
>> + (let ((src-file (car command-line-args-left))
>> + (dst-file (cadr command-line-args-left))
>> + (coding-system-for-write 'utf-8-emacs))
>
> This should be 'utf-8-unix. There's no reason to write out stuff in
> our internal encoding, as the file is not supposed to have any
> characters not representable in UTF-8.
>
> Otherwise, this LGTM. Let's wait for a few days for more comments,
> and then push.
Doesn't look like anything more is forthcoming, shall I push to master?
next prev parent reply other threads:[~2019-02-24 5:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 5:34 bug#34215: 27.0.50; Provide elisp access to Chinese pinyin-to-character mapping Eric Abrahamsen
2019-01-27 15:41 ` Eli Zaretskii
2019-01-27 18:02 ` Eric Abrahamsen
2019-01-27 18:14 ` Eli Zaretskii
2019-01-27 19:18 ` Eric Abrahamsen
2019-01-27 19:48 ` Eli Zaretskii
2019-01-29 17:48 ` Eric Abrahamsen
2019-01-30 17:09 ` Eli Zaretskii
2019-01-30 20:33 ` Eric Abrahamsen
2019-01-30 20:48 ` Eric Abrahamsen
2019-01-31 8:50 ` Robert Pluim
2019-01-31 19:35 ` Eric Abrahamsen
2019-02-01 9:48 ` Eli Zaretskii
2019-02-01 16:27 ` Eric Abrahamsen
2019-02-01 18:53 ` Eli Zaretskii
2019-02-01 19:15 ` Eric Abrahamsen
2019-02-24 5:36 ` Eric Abrahamsen [this message]
2019-02-24 16:06 ` Eli Zaretskii
2019-02-24 18:53 ` Eric Abrahamsen
2019-02-24 19:12 ` bug#34215: Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftsd3fzp.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=34215@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).