From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34655: 26.1.92; Segfault in module with --module-assertions Date: Thu, 21 Mar 2019 21:29:14 +0000 Message-ID: <87ftrfex1x.fsf@tcd.ie> References: <874l8r1t3a.fsf@tcd.ie> <8336oamu3y.fsf@gnu.org> <87h8c1cv6l.fsf@tcd.ie> <83lg1dwhse.fsf@gnu.org> <87va0h12js.fsf@tcd.ie> <835zsgw3ui.fsf@gnu.org> <87ef7486h0.fsf@tcd.ie> <83r2b4ul1c.fsf@gnu.org> <831s30upqd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="18293"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34655@debbugs.gnu.org, Stefan Monnier To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 21 22:30:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h75GS-0004ey-NN for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 22:30:16 +0100 Original-Received: from localhost ([127.0.0.1]:47080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h75GR-0004Xs-Nd for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 17:30:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h75GJ-0004Xj-TT for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 17:30:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h75GH-0006bB-Sv for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 17:30:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40200) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h75GE-0006Wq-JZ for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 17:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h75GE-0005hQ-7h for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Mar 2019 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34655 X-GNU-PR-Package: emacs Original-Received: via spool by 34655-submit@debbugs.gnu.org id=B34655.155320376921846 (code B ref 34655); Thu, 21 Mar 2019 21:30:02 +0000 Original-Received: (at 34655) by debbugs.gnu.org; 21 Mar 2019 21:29:29 +0000 Original-Received: from localhost ([127.0.0.1]:53744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h75Fh-0005gI-8l for submit@debbugs.gnu.org; Thu, 21 Mar 2019 17:29:29 -0400 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:37921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h75Ff-0005g2-2h for 34655@debbugs.gnu.org; Thu, 21 Mar 2019 17:29:27 -0400 Original-Received: by mail-ed1-f45.google.com with SMTP id q14so6295090edr.5 for <34655@debbugs.gnu.org>; Thu, 21 Mar 2019 14:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=onfi3pQ2QGSrLt1t8y12+okWY2xSUoC7UWVT9+4NaxE=; b=Or7ViLUkj4pYZoMAZTQQby+MDmYx+9zWk8o/h6lwB1Luwrt//EVqplGQp+Kv3vzILm g8EHQWpk7wCtKV/31QOyT9ZFWi/zlyPBDv+OHkNXcjSEC8SeY6EIOBbvDiwnkNnNrLAF c3vxJYGWx3Ye4YiDdr6BCzFHWxCYS8e6cQgWoP3bWVtSS7HfxyCYiuIjTewKOIPc43r+ zzCai/3Qvv5I4DxPVjmTPJP1N0dxpckh6enlKybJdJiCKrEOr8PUoihh2FDbOvoAHxL7 FORAMhnfNsm0HORYYjPc4EcBLcad2omNzShKLAO6p5xOAWqq6BgU823BcSSu5up3YUsS I2Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=onfi3pQ2QGSrLt1t8y12+okWY2xSUoC7UWVT9+4NaxE=; b=jKPOMu2weA/LA2NQj1ReFJexjS0W0qfxzbpxlquwcMxDPwPaPbd+JoZvpq9GXPxcLD Au6wX55GcqiNFDBk94Vo2FlrX13RXmbLiDqe4PoSv00MnEtpN6b6H9715iB6+19YF5BN 7wB4CCQkrA4jBCyLy7YceIJFqcvRF0oaaZowoR3KHDrfSq1zxTPbznw8IiJ4+UrVfdvH UuVshSIYwumYnHbyW07lV5p3vv3S37VYnWECflRzGv3CujorGorsKlitm2SIakGmjm+X 4FdhOTe58zofXn7QvL8OkzBh5JztwqpBbOGyLhZrmNGkOAzauKEo5aCK74doaYluLz/L /MOQ== X-Gm-Message-State: APjAAAXGaSoNI67KztcZmtVcEjwEzlEI1xCFQDcJVAd+BrA6ds0QndRv fTocSJivcgzuHL4CwaRVTmbxVg== X-Google-Smtp-Source: APXvYqxAryo/4AYFoYyc0HIwlVMJArfPKD03U1KRZ1givUtzwqhlXY9KRZNoLdIyojARISw8onlX9w== X-Received: by 2002:a17:906:f44:: with SMTP id h4mr3358239ejj.4.1553203761325; Thu, 21 Mar 2019 14:29:21 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:20c2:134e:4f3a:683a]) by smtp.gmail.com with ESMTPSA id y12sm914474eju.43.2019.03.21.14.29.20 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 21 Mar 2019 14:29:20 -0700 (PDT) In-Reply-To: (Philipp Stephani's message of "Thu, 21 Mar 2019 20:23:30 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156591 Archived-At: Philipp Stephani writes: > Am Do., 21. M=C3=A4rz 2019 um 19:28 Uhr schrieb Philipp Stephani > : >> >> Am Do., 21. M=C3=A4rz 2019 um 18:00 Uhr schrieb Eli Zaretskii : >> > >> > > From: Philipp Stephani >> > > Date: Thu, 21 Mar 2019 17:11:41 +0100 >> > > Cc: "Basil L. Contovounesios" , 34655@debbugs.gnu.o= rg >> > > >> > > I haven't checked everything in detail, but my impression is that th= is >> > > is rather another instance of bug#31238. Fixing this only when module >> > > assertions are enabled will probably not fix anything, but rather ma= sk >> > > issues. Reverting commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a is >> > > still the right approach here. Can you please hold off a bit? I've >> > > almost completed the revert, but haven't pushed it yet. Once that's = in >> > > we can check whether it also fixes this issue. >> > >> > I will CC Stefan, who committed 3eb93c07f7a60ac9ce8a16f10c3afd5a3a3124= 3a. >> > >> > I'm not sure we should revert that; we could instead add GC protection >> > for those parts that need it. >> >> Yes, that's what reverting that commit does :-) >> We need to mark the objects in all cases, not just when module >> assertions are enabled. >> Note that both the designer of the module API (Daniel) and I as one of >> its main implementers disagree with commit >> 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a. I'm happy to discuss >> alternatives, but for now we should revert it and discuss the >> alternatives *before* implementing them. I've already confirmed that >> reverting commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a fixes >> bug#31238, and I can try it with this bug as well. > > I wasn't able to reproduce bug#34655 myself (these things tend to be > rather flaky), but I've now reverted commit > 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a, and at least bug#31238 is > now consistently fixed (for me at least). Basil, can you check whether > you can still reproduce bug#34655 with the current master? FWIW, I cannot reproduce bug#34655 after reverting Stefan's commit. Thanks, --=20 Basil