From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#34972: [PATCH] Inhibit displaying help buffer in main window in perform-replace Date: Thu, 11 Apr 2019 23:56:51 +0300 Organization: LINKOV.NET Message-ID: <87ftqo2rcc.fsf_-_@mail.linkov.net> References: <87wokophsk.fsf@gmail.com> <87d0m6regr.fsf@mail.linkov.net> <87imvyytqj.fsf@gmail.com> <877ecdee8s.fsf@mail.linkov.net> <871s2avwj8.fsf@gmail.com> <87pnptfuvq.fsf@mail.linkov.net> <2e93aa6c-e43b-4744-9f06-705bfe598174@default> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="41596"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: =?UTF-8?Q?Micha=C5=82?= Krzywkowski , 34972@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 11 22:59:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEgn0-000Agg-VB for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 22:59:19 +0200 Original-Received: from localhost ([127.0.0.1]:54830 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEgmz-0001KJ-PU for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 16:59:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEgmp-0001K1-Rg for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 16:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEgmn-0003hK-5t for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 16:59:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEgmk-0003g8-Jw for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 16:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEgmk-0000yI-5g for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 16:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Apr 2019 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34972 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34972-submit@debbugs.gnu.org id=B34972.15550163003682 (code B ref 34972); Thu, 11 Apr 2019 20:59:02 +0000 Original-Received: (at 34972) by debbugs.gnu.org; 11 Apr 2019 20:58:20 +0000 Original-Received: from localhost ([127.0.0.1]:55221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEgm4-0000xJ-F8 for submit@debbugs.gnu.org; Thu, 11 Apr 2019 16:58:20 -0400 Original-Received: from palegreen.birch.relay.mailchannels.net ([23.83.209.140]:60447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEgm2-0000x8-Lp; Thu, 11 Apr 2019 16:58:19 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 677A712544D; Thu, 11 Apr 2019 20:58:17 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a66.g.dreamhost.com (unknown [100.96.20.50]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A95221254AE; Thu, 11 Apr 2019 20:58:16 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a66.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Thu, 11 Apr 2019 20:58:17 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Sponge-Keen: 6957c75910e6f02b_1555016297016_3409711893 X-MC-Loop-Signature: 1555016297016:113251072 X-MC-Ingress-Time: 1555016297015 Original-Received: from pdx1-sub0-mail-a66.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a66.g.dreamhost.com (Postfix) with ESMTP id 3BEB880723; Thu, 11 Apr 2019 13:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=dC/8hkbVSy/qwlvLTHTvg7Vw25w=; b= 1ndPQ8STCSFLlO7syMunm2vTq/Y3IXyz56lpwhdzZEi+BfsywLV40C4hhYUCPSBs Ep6ZPsBfILvfAYF4YfLG3YCakJAjfNAxzpgcKKwE0lnWY/jeHBUySxNP2r5lT9nH 4D0cAQc0JOxUNJ9MUbzE5FZrmhPEqYD2kgPjP6MnE6Y= Original-Received: from mail.jurta.org (m91-129-111-111.cust.tele2.ee [91.129.111.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a66.g.dreamhost.com (Postfix) with ESMTPSA id 021BE8071D; Thu, 11 Apr 2019 13:58:13 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a66 In-Reply-To: <2e93aa6c-e43b-4744-9f06-705bfe598174@default> (Drew Adams's message of "Wed, 10 Apr 2019 14:02:31 -0700 (PDT)") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrudelgdduheeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdduuddurdduuddunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrudduuddrudduuddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157520 Archived-At: --=-=-= Content-Type: text/plain retitle 34972 [PATCH] Inhibit displaying help buffer in main window in perform-replace thanks > Please consider retitling the bug, as it (the solution, at > least) is not about renaming the *Help* buffer. A worse problem is that when 'log-edit-insert-changelog' inserts the author, it removes the 'log-edit-summary' face from the summary line, this is confusing. This patch fixes this usability issue by inserting the explicit Summary: field in case if other fields are inserted: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=log-edit-add-field-summary.patch diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el index 42710dd8dc..ba5a1a3d57 100644 --- a/lisp/vc/log-edit.el +++ b/lisp/vc/log-edit.el @@ -754,7 +754,9 @@ log-edit-insert-changelog (log-edit-insert-changelog-entries (log-edit-files))))) (log-edit-set-common-indentation) ;; Add an Author: field if appropriate. - (when author (log-edit-add-field "Author" (car author))) + (when author + (log-edit-add-field "Author" (car author)) + (log-edit-add-field "Summary" "")) ;; Add a Fixes: field if applicable. (when (consp log-edit-rewrite-fixes) (rfc822-goto-eoh) --=-=-=--