From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect Date: Wed, 17 Apr 2019 23:29:10 +0300 Organization: LINKOV.NET Message-ID: <87ftqgpe95.fsf@mail.linkov.net> References: <87lg2x6fox.fsf@mail.linkov.net> <87h8dkk3ho.fsf@mail.linkov.net> <87y36w8qvy.fsf@gmail.com> <87o97ruu06.fsf@mail.linkov.net> <87bm3rxjkd.fsf@gmail.com> <87k1hy19ug.fsf@mail.linkov.net> <87d0mn3op7.fsf@mail.linkov.net> <878sxak3ew.fsf@mail.linkov.net> <87d0mct2ut.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="138492"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 34294@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 17 22:37:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGrJ4-000Ztd-RG for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Apr 2019 22:37:23 +0200 Original-Received: from localhost ([127.0.0.1]:59385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGrJ3-0000Of-F7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Apr 2019 16:37:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGrIp-0000MY-RI for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2019 16:37:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGrIn-0001EW-Sz for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2019 16:37:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGrIk-00013g-HW for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2019 16:37:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hGrIk-0001Y7-9V for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2019 16:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Apr 2019 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34294 X-GNU-PR-Package: emacs Original-Received: via spool by 34294-submit@debbugs.gnu.org id=B34294.15555333995911 (code B ref 34294); Wed, 17 Apr 2019 20:37:02 +0000 Original-Received: (at 34294) by debbugs.gnu.org; 17 Apr 2019 20:36:39 +0000 Original-Received: from localhost ([127.0.0.1]:40837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGrIN-0001XH-Kd for submit@debbugs.gnu.org; Wed, 17 Apr 2019 16:36:39 -0400 Original-Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:18511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGrIL-0001X7-8s for 34294@debbugs.gnu.org; Wed, 17 Apr 2019 16:36:38 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4960F5C5A10; Wed, 17 Apr 2019 20:36:36 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (unknown [100.96.16.23]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3B4705C5BA5; Wed, 17 Apr 2019 20:36:35 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Wed, 17 Apr 2019 20:36:36 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Suffer-Share: 7e35dcea39b7cb90_1555533395466_263923463 X-MC-Loop-Signature: 1555533395466:4196642461 X-MC-Ingress-Time: 1555533395466 Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTP id 1437F800AE; Wed, 17 Apr 2019 13:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=dB61rkHw+OP7QMhDb4T38g0Tfrk=; b= IUv+bAEmOV6k+kU0HqYK2zNgUiobxYAcOivYJNCcGwwr1uiGmIzsmpZLay32W045 IP46JrifcnuQiu81wekrVyAO4ObXLgGfCLLfMYwr3Dto0TZhICYWTCC7+uJ44DoE 0GGc1Hh4+r56Rjg8G4I1xXnnmZ6NuMFeU/b4iox6YnE= Original-Received: from mail.jurta.org (m91-129-111-111.cust.tele2.ee [91.129.111.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTPSA id 7EE56800A5; Wed, 17 Apr 2019 13:36:28 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a37 In-Reply-To: <87d0mct2ut.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 27 Mar 2019 23:38:18 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrfeefgdduheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdduuddurdduuddunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrudduuddrudduuddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehjohgrohhtrghvohhrrgesghhmrghilhdrtghomhenucevlhhushhtvghrufhiiigvpedv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157779 Archived-At: > Could you please also push an additional patch that fixes > a race condition in flymake. The problem is that currently > flymake starts even when flymake-mode is disabled. More problems: when an error is shown in the tooltip, currently there is no way to copy a solution sometimes provided as part of the tooltip text. This fix allows the tooltip text to be added to the *Messages* buffer: @@ -640,10 +644,11 @@ flymake--highlight-line (default-maybe 'help-echo (lambda (window _ov pos) (with-selected-window window - (mapconcat - #'flymake--diag-text - (flymake-diagnostics pos) - "\n")))) + (let ((inhibit-message t)) + (message "%s" (mapconcat + #'flymake--diag-text + (flymake-diagnostics pos) + "\n")))))) (default-maybe 'severity (warning-numeric-level :error)) (default-maybe 'priority (+ 100 (overlay-get ov 'severity)))) ;; Some properties can't be overridden.