unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: "João Távora" <joaotavora@gmail.com>
Cc: 34294@debbugs.gnu.org
Subject: bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect
Date: Wed, 17 Apr 2019 23:29:10 +0300	[thread overview]
Message-ID: <87ftqgpe95.fsf@mail.linkov.net> (raw)
In-Reply-To: <87d0mct2ut.fsf@mail.linkov.net> (Juri Linkov's message of "Wed,  27 Mar 2019 23:38:18 +0200")

> Could you please also push an additional patch that fixes
> a race condition in flymake.  The problem is that currently
> flymake starts even when flymake-mode is disabled.

More problems: when an error is shown in the tooltip, currently there is
no way to copy a solution sometimes provided as part of the tooltip text.

This fix allows the tooltip text to be added to the *Messages* buffer:

@@ -640,10 +644,11 @@ flymake--highlight-line
       (default-maybe 'help-echo
         (lambda (window _ov pos)
           (with-selected-window window
-            (mapconcat
-             #'flymake--diag-text
-             (flymake-diagnostics pos)
-             "\n"))))
+            (let ((inhibit-message t))
+              (message "%s" (mapconcat
+                             #'flymake--diag-text
+                             (flymake-diagnostics pos)
+                             "\n"))))))
       (default-maybe 'severity (warning-numeric-level :error))
       (default-maybe 'priority (+ 100 (overlay-get ov 'severity))))
     ;; Some properties can't be overridden.





  reply	other threads:[~2019-04-17 20:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02 21:30 bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect Juri Linkov
2019-02-02 22:40 ` João Távora
2019-02-03 20:42   ` Juri Linkov
2019-02-03 22:10     ` João Távora
2019-02-04 21:24       ` Juri Linkov
2019-02-04 22:41         ` João Távora
2019-02-17 20:11           ` Juri Linkov
2019-03-18 21:10             ` Juri Linkov
2019-03-18 21:43               ` João Távora
2019-03-19 20:46                 ` Juri Linkov
2019-03-27 21:38                   ` Juri Linkov
2019-04-17 20:29                     ` Juri Linkov [this message]
2019-04-18 11:36                       ` João Távora
2019-04-18 20:42                         ` Juri Linkov
2019-04-19  6:35                           ` Eli Zaretskii
2019-04-24 20:25                             ` Juri Linkov
2019-04-25  5:46                               ` Eli Zaretskii
2019-04-25  8:07                               ` martin rudalics
2019-04-29 20:15                                 ` Juri Linkov
2019-05-01  8:29                                   ` martin rudalics
2019-05-01 21:10                                     ` Juri Linkov
2019-05-04 17:34                                       ` martin rudalics
2019-05-04 21:16                                         ` Juri Linkov
2019-05-05  9:04                                           ` martin rudalics
2019-05-05 22:46                                             ` Richard Stallman
2019-05-05 23:09                                               ` João Távora
2019-05-05 20:08 ` Juri Linkov
2019-05-05 23:02   ` João Távora
2019-05-06 20:15     ` Juri Linkov
2019-05-07 20:29       ` Juri Linkov
2019-05-07 23:10         ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftqgpe95.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=34294@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).