* bug#35613: Cursor returns to wrong article!
@ 2019-05-07 1:41 積丹尼 Dan Jacobson
2019-05-07 13:10 ` Basil L. Contovounesios
0 siblings, 1 reply; 6+ messages in thread
From: 積丹尼 Dan Jacobson @ 2019-05-07 1:41 UTC (permalink / raw)
To: 35613
I discovered a massive bug. A bug that could cause the user to lose mail.
In the *Summary* buffer use a few
<down> [next-line]
until the cursor is upon call it, article A.
<return> [gnus-summary-scroll-up]
<down> [next-line] (once or more)
<return> [gnus-summary-scroll-up]
<tab> [gnus-summary-widget-forward]
= [gnus-article-read-summary-keys]
Even though the ">" arrow at left and the underline are on a different article,
but the cursor now returns to Article A!!
Now if he hits e.g., the E key, he will mark the wrong article!
Or if he forwards it to his grandmother, she will die because he
forwarded the wrong article and she had a heart attack. See, gnus kills people!
Sure you will argue that that is a feature, however I used the same
<return> [gnus-summary-scroll-up]
twice and for no good reason you remember the first one.
Gnus v5.13
GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.4)
of 2019-02-03, modified by Debian
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#35613: Cursor returns to wrong article!
2019-05-07 1:41 bug#35613: Cursor returns to wrong article! 積丹尼 Dan Jacobson
@ 2019-05-07 13:10 ` Basil L. Contovounesios
2019-05-08 3:43 ` 積丹尼 Dan Jacobson
2019-05-17 0:00 ` Basil L. Contovounesios
0 siblings, 2 replies; 6+ messages in thread
From: Basil L. Contovounesios @ 2019-05-07 13:10 UTC (permalink / raw)
To: 積丹尼 Dan Jacobson; +Cc: 35613
[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]
tags 35613 + patch
quit
積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> I discovered a massive bug. A bug that could cause the user to lose mail.
>
> In the *Summary* buffer use a few
> <down> [next-line]
> until the cursor is upon call it, article A.
> <return> [gnus-summary-scroll-up]
> <down> [next-line] (once or more)
> <return> [gnus-summary-scroll-up]
> <tab> [gnus-summary-widget-forward]
> = [gnus-article-read-summary-keys]
> Even though the ">" arrow at left and the underline are on a different article,
> but the cursor now returns to Article A!!
>
> Now if he hits e.g., the E key, he will mark the wrong article!
> Or if he forwards it to his grandmother, she will die because he
> forwarded the wrong article and she had a heart attack. See, gnus kills people!
>
> Sure you will argue that that is a feature, however I used the same
> <return> [gnus-summary-scroll-up]
> twice and for no good reason you remember the first one.
>
> Gnus v5.13
> GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.4)
> of 2019-02-03, modified by Debian
This is the user option switch-to-buffer-preserve-window-point in
action. If you customise it to nil, the behaviour you describe should
go away.
This is why Elisp programs should usually use pop-to-buffer et
al. instead of switch-to-buffer et al. The following patch should fix
that for this case:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-gnus-summary-expand-window-placement-of-point.patch --]
[-- Type: text/x-diff, Size: 1078 bytes --]
From 1d7a51d2e3a1c3d5caa77587b3e612feda8bdd59 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Tue, 7 May 2019 13:46:22 +0100
Subject: [PATCH] Fix gnus-summary-expand-window placement of point
* lisp/gnus/gnus-win.el (gnus-configure-frame): Replace
switch-to-buffer with pop-to-buffer-same-window to avoid messing
with point. (bug#35613)
---
lisp/gnus/gnus-win.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/gnus/gnus-win.el b/lisp/gnus/gnus-win.el
index 5f7154c545..c6469f4937 100644
--- a/lisp/gnus/gnus-win.el
+++ b/lisp/gnus/gnus-win.el
@@ -284,7 +284,7 @@ gnus-configure-frame
;; from a hard-dedicated frame, it creates (and
;; configures) a new frame, leaving the dedicated frame alone.
(pop-to-buffer buf))
- (t (switch-to-buffer buf)))))
+ (t (pop-to-buffer-same-window buf)))))
(when (memq 'frame-focus split)
(setq gnus-window-frame-focus window))
;; We return the window if it has the `point' spec.
--
2.20.1
[-- Attachment #3: Type: text/plain, Size: 100 bytes --]
I'll push it to master in a week or so if there are no objections before
then.
Thanks,
--
Basil
^ permalink raw reply related [flat|nested] 6+ messages in thread* bug#35613: Cursor returns to wrong article!
2019-05-07 13:10 ` Basil L. Contovounesios
@ 2019-05-08 3:43 ` 積丹尼 Dan Jacobson
2019-05-08 12:09 ` Basil L. Contovounesios
2019-05-17 0:00 ` Basil L. Contovounesios
1 sibling, 1 reply; 6+ messages in thread
From: 積丹尼 Dan Jacobson @ 2019-05-08 3:43 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: 35613
Thanks. I suppose the temporary workaround is
(add-hook 'gnus-summary-mode-hook
(lambda ()
(setq switch-to-buffer-preserve-window-point nil))) ;until bug#35613 fixed
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#35613: Cursor returns to wrong article!
2019-05-08 3:43 ` 積丹尼 Dan Jacobson
@ 2019-05-08 12:09 ` Basil L. Contovounesios
2019-05-08 12:27 ` 積丹尼 Dan Jacobson
0 siblings, 1 reply; 6+ messages in thread
From: Basil L. Contovounesios @ 2019-05-08 12:09 UTC (permalink / raw)
To: 積丹尼 Dan Jacobson; +Cc: 35613
積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> Thanks. I suppose the temporary workaround is
> (add-hook 'gnus-summary-mode-hook
> (lambda ()
> (setq switch-to-buffer-preserve-window-point nil))) ;until bug#35613 fixed
Doing that will change the global value of
switch-to-buffer-preserve-window-point. If you're okay with doing that,
why bother with gnus-summary-mode-hook at all? Just set the user option
once and for all.
Alternatively, if you want to localise the change, you can instead:
(add-hook 'gnus-article-mode-hook
(lambda ()
(setq-local switch-to-buffer-preserve-window-point nil)))
--
Basil
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#35613: Cursor returns to wrong article!
2019-05-07 13:10 ` Basil L. Contovounesios
2019-05-08 3:43 ` 積丹尼 Dan Jacobson
@ 2019-05-17 0:00 ` Basil L. Contovounesios
1 sibling, 0 replies; 6+ messages in thread
From: Basil L. Contovounesios @ 2019-05-17 0:00 UTC (permalink / raw)
To: 積丹尼 Dan Jacobson; +Cc: 35613-done
tags 35613 fixed
close 35613
quit
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> From 1d7a51d2e3a1c3d5caa77587b3e612feda8bdd59 Mon Sep 17 00:00:00 2001
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Tue, 7 May 2019 13:46:22 +0100
> Subject: [PATCH] Fix gnus-summary-expand-window placement of point
>
> * lisp/gnus/gnus-win.el (gnus-configure-frame): Replace
> switch-to-buffer with pop-to-buffer-same-window to avoid messing
> with point. (bug#35613)
> ---
> lisp/gnus/gnus-win.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/gnus/gnus-win.el b/lisp/gnus/gnus-win.el
> index 5f7154c545..c6469f4937 100644
> --- a/lisp/gnus/gnus-win.el
> +++ b/lisp/gnus/gnus-win.el
> @@ -284,7 +284,7 @@ gnus-configure-frame
> ;; from a hard-dedicated frame, it creates (and
> ;; configures) a new frame, leaving the dedicated frame alone.
> (pop-to-buffer buf))
> - (t (switch-to-buffer buf)))))
> + (t (pop-to-buffer-same-window buf)))))
> (when (memq 'frame-focus split)
> (setq gnus-window-frame-focus window))
> ;; We return the window if it has the `point' spec.
> --
> 2.20.1
>
>
> I'll push it to master in a week or so if there are no objections before
> then.
Now done[1], so I'm closing this report.
[1: 9408e36b84]: Fix gnus-summary-expand-window placement of point
2019-05-17 00:55:58 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9408e36b84b8e81dd9f4d1465c4f20f125d4bd06
--
Basil
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-17 0:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-07 1:41 bug#35613: Cursor returns to wrong article! 積丹尼 Dan Jacobson
2019-05-07 13:10 ` Basil L. Contovounesios
2019-05-08 3:43 ` 積丹尼 Dan Jacobson
2019-05-08 12:09 ` Basil L. Contovounesios
2019-05-08 12:27 ` 積丹尼 Dan Jacobson
2019-05-17 0:00 ` Basil L. Contovounesios
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).