From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rolf Ade Newsgroups: gmane.emacs.bugs Subject: bug#25379: 26.0.50; Minor: Call looking-back as advertised Date: Tue, 30 Jul 2019 23:41:23 +0200 Message-ID: <87ftmnurng.fsf@pointsman.de> References: <87y3yooxbo.fsf@pointsman.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99472"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) To: 25379-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 30 23:42:48 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsZtN-000Pid-EW for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jul 2019 23:42:45 +0200 Original-Received: from localhost ([::1]:36560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsZtL-0004F1-V6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jul 2019 17:42:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43121) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsZsj-0004Eb-2e for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 17:42:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsZsg-0003O1-Ps for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 17:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hsZsg-0003Mc-Dh for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 17:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hsZsg-0004f0-93 for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 17:42:02 -0400 Resent-From: Rolf Ade Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jul 2019 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25379 X-GNU-PR-Package: emacs Mail-Followup-To: 25379@debbugs.gnu.org, rolf@pointsman.de, rolf@pointsman.de Original-Received: via spool by 25379-done@debbugs.gnu.org id=D25379.156452289617848 (code D ref 25379); Tue, 30 Jul 2019 21:42:02 +0000 Original-Received: (at 25379-done) by debbugs.gnu.org; 30 Jul 2019 21:41:36 +0000 Original-Received: from localhost ([127.0.0.1]:51316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsZsG-0004dn-Dc for submit@debbugs.gnu.org; Tue, 30 Jul 2019 17:41:36 -0400 Original-Received: from mxout5.interscholz.de ([85.236.196.72]:52366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsZsD-0004dY-8J for 25379-done@debbugs.gnu.org; Tue, 30 Jul 2019 17:41:34 -0400 Original-Received: from localhost (mxout5 [127.0.0.1]) by mxout5.interscholz.de (Postfix) with ESMTP id 18680268A4 for <25379-done@debbugs.gnu.org>; Tue, 30 Jul 2019 23:41:19 +0200 (CEST) X-Virus-Scanned: interscholz amavisd-new at mxout5.interscholz.de Original-Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout5.interscholz.de (Postfix) with ESMTP id 4CBB620BF5 for <25379-done@debbugs.gnu.org>; Tue, 30 Jul 2019 23:41:16 +0200 (CEST) Original-Received: from pointsman2 (p5B317A9C.dip0.t-ipconnect.de [91.49.122.156]) by server.web01.interscholz.net (Postfix) with ESMTPSA id D2DC7340371; Tue, 30 Jul 2019 23:41:22 +0200 (CEST) In-Reply-To: <87y3yooxbo.fsf@pointsman.de> (Rolf Ade's message of "Fri, 06 Jan 2017 19:30:35 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164140 Archived-At: Rolf Ade writes: > Since emacs 25.1 > > C-h f looking-back RET > > shows: > > looking-back is a compiled Lisp function in =E2=80=98subr.el=E2=80=99. > > (looking-back REGEXP LIMIT &optional GREEDY) > ... > > This is because of > > (declare > (advertised-calling-convention (regexp limit &optional greedy) "25.1")) > > at the start of the looking-back implementation. > > It still can be called with only one argument (in this cases LIMIT will > default to nil) and there are still a few such calls in the emacs core > lisp code. > > This doesn't do any harm other than unnecessary > > "[...]Warning: looking-back called with 1 argument, but requires 2-3" > > noise in the compiling output while byte-compiling that files. > > The patch below silence that (simply by explicitly adding nil as second > argument). This handles all such calls, that an el-search-load-path with > the pattern `(looking-back ,_) found (see > https://elpa.gnu.org/packages/el-search.html) with an appropriate > load-path. That means, if that works as promoted: this patch handles all > such cases curently still in the core. > > Commit message: > > * lisp/emulation/viper-ex.el (ex-cmd-read-exit): > * lisp/org/org.el (org-read-date-minibuffer-local-map): > * lisp/progmodes/hideshow.el (hs-hide-block-at-point): > * lisp/progmodes/sql.el (sql-end-of-statement): Call looking-back as > advertised. > > Copyright-paperwork-exempt: yes > > > diff --git a/lisp/emulation/viper-ex.el b/lisp/emulation/viper-ex.el > index edc71ea..3fdeadb 100644 > --- a/lisp/emulation/viper-ex.el > +++ b/lisp/emulation/viper-ex.el > @@ -548,9 +548,9 @@ ex-cmd-read-exit > (setq viper-ex-work-buf (get-buffer-create viper-ex-work-buf-name)) > (set-buffer viper-ex-work-buf) > (goto-char (point-max))) > - (cond ((looking-back quit-regex1) (exit-minibuffer)) > - ((looking-back stay-regex) (insert " ")) > - ((looking-back quit-regex2) (exit-minibuffer)) > + (cond ((looking-back quit-regex1 nil) (exit-minibuffer)) > + ((looking-back stay-regex nil) (insert " ")) > + ((looking-back quit-regex2 nil) (exit-minibuffer)) > (t (insert " "))))) >=20=20 > (declare-function viper-tmp-insert-at-eob "viper-cmd" (msg)) > diff --git a/lisp/org/org.el b/lisp/org/org.el > index 02a7a0c..2659a4d 100644 > --- a/lisp/org/org.el > +++ b/lisp/org/org.el > @@ -16249,7 +16249,7 @@ org-read-date-minibuffer-local-map > (org-defkey map (kbd ".") > (lambda () (interactive) > ;; Are we at the beginning of the prompt? > - (if (looking-back "^[^:]+: ") > + (if (looking-back "^[^:]+: " nil) > (org-eval-in-calendar '(calendar-goto-today)) > (insert ".")))) > (org-defkey map (kbd "C-.") > diff --git a/lisp/progmodes/hideshow.el b/lisp/progmodes/hideshow.el > index 0e4e670..5328526 100644 > --- a/lisp/progmodes/hideshow.el > +++ b/lisp/progmodes/hideshow.el > @@ -582,7 +582,7 @@ hs-hide-block-at-point > (setq p (line-end-position))) > ;; `q' is the point at the end of the block > (hs-forward-sexp mdata 1) > - (setq q (if (looking-back hs-block-end-regexp) > + (setq q (if (looking-back hs-block-end-regexp nil) > (match-beginning 0) > (point))) > (when (and (< p q) (> (count-lines p q) 1)) > diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el > index d6c9516..06ef4df 100644 > --- a/lisp/progmodes/sql.el > +++ b/lisp/progmodes/sql.el > @@ -2790,7 +2790,7 @@ sql-end-of-statement > ;; Iterate until we've moved the desired number of stmt ends > (while (not (=3D (cl-signum arg) 0)) > ;; if we're looking at the terminator, jump by 2 > - (if (or (and (> 0 arg) (looking-back term)) > + (if (or (and (> 0 arg) (looking-back term nil)) > (and (< 0 arg) (looking-at term))) > (setq n 2) > (setq n 1)) > > > > In GNU Emacs 26.0.50.5 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) > of 2017-01-06 built on linux-qg7d > Repository revision: 8f0376309ee37e4f1da21d78971c4df2df5fd7b6 > Windowing system distributor 'The X.Org Foundation', version 11.0.11203000 > System Description: openSUSE 12.2 (x86_64) All the in this bug mentioned looking-at are in the meantimenow called with the advertised two args; no warning message regarding to this created anymore. This was done. (By others, mostly in the way I proposed in my patch.)