On Fri 05 Jul 2019 at 23:17, Noam Postavsky <npostavs@gmail.com> wrote:

> Alex Branham <alex.branham@gmail.com> writes:
>
>> OK, here's a patch that does so. The general idea is to make a minor
>> mode with its own keymap for each of eshell's modules that (previously)
>> assigned their keybindings into eshell-mode-map.
>
> Looks like this loses the keybindings from C-h m.  Is it possible to
> keep those?  Or failing that, add them to the new minor mode docs.

Sorry for the delayed reply.

I don't know of a straightforward way to keep those in C-h m since this
uses minor modes, but it's easy enough to add those into the docstring
of the minor mode.

The more I think about this the more I wonder whether the whole
eshell-module framework should just be moved to minor modes, then we
could just call run-hooks on eshell-modules to set everything up. But
that's a question for a later day I suppose.

Thanks,
Alex