From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37758: 27.0.50; Support multibyte characters in function 'auth-source--pad'an; with patch Date: Tue, 15 Oct 2019 08:43:58 +0200 Message-ID: <87ftjuqzip.fsf@gnus.org> References: <875zkqd8ol.wl-mgcyung@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="125610"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37758@debbugs.gnu.org To: mgcyung Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 15 08:45:30 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKGaF-000WVn-FS for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 08:45:27 +0200 Original-Received: from localhost ([::1]:35200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKGaE-0000tK-5q for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 02:45:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43568) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKGZv-0000oe-CF for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 02:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKGZq-00039L-Cd for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 02:45:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKGZq-00038o-8Z for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 02:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKGZq-0004TO-5Q for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 02:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 06:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37758 X-GNU-PR-Package: emacs Original-Received: via spool by 37758-submit@debbugs.gnu.org id=B37758.157112184617098 (code B ref 37758); Tue, 15 Oct 2019 06:45:02 +0000 Original-Received: (at 37758) by debbugs.gnu.org; 15 Oct 2019 06:44:06 +0000 Original-Received: from localhost ([127.0.0.1]:42609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKGYv-0004Ri-Rg for submit@debbugs.gnu.org; Tue, 15 Oct 2019 02:44:06 -0400 Original-Received: from [80.91.231.51] (port=50798 helo=quimby.gnus.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKGYt-0004RV-Qt for 37758@debbugs.gnu.org; Tue, 15 Oct 2019 02:44:04 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKGYp-0001AU-3I; Tue, 15 Oct 2019 08:44:01 +0200 In-Reply-To: <875zkqd8ol.wl-mgcyung@gmail.com> (mgcyung@gmail.com's message of "Tue, 15 Oct 2019 10:49:46 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169357 Archived-At: mgcyung writes: > 'auth-source--pad' use 'length' to get byte length of a > string. However, 'length' return the number of characters which is not > the byte length with multibyte characters such as Chinese > character. This may causes an error "GnuTLS cipher > AES-256-CBC/encrypt input block length xxxx is not a multiple of the > required 16". > > According to the doc of 'length'. 'length' can be replaced by > 'string-bytes'. And a patch is attached. Thanks for the patch, but I don't think it's a quite safe change. Instead the string should be made into a sequence of bytes before padding (and converted back again afterwards) to ensure that it survives the encryption, I think. I've now made this change on the trunk. Could you check that it works for you? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no