From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#26932: Found the triggering behaviour Date: Wed, 23 Oct 2019 12:02:21 +0200 Message-ID: <87ftjjixua.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="9582"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 26932@debbugs.gnu.org To: Vivek Dasmohapatra Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 12:04:02 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNDUn-0002Ec-SH for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 12:04:01 +0200 Original-Received: from localhost ([::1]:59608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNDUm-0003dp-51 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 06:04:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39471) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNDTt-0003dA-3H for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 06:03:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNDTq-0008Qy-Os for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 06:03:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNDTq-0008Qt-Kb for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 06:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNDTq-0000eG-F7 for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 06:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 10:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26932 X-GNU-PR-Package: emacs Original-Received: via spool by 26932-submit@debbugs.gnu.org id=B26932.15718249471512 (code B ref 26932); Wed, 23 Oct 2019 10:03:02 +0000 Original-Received: (at 26932) by debbugs.gnu.org; 23 Oct 2019 10:02:27 +0000 Original-Received: from localhost ([127.0.0.1]:60937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNDTG-0000Nz-Hd for submit@debbugs.gnu.org; Wed, 23 Oct 2019 06:02:26 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:34732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNDTF-0000MV-3H for 26932@debbugs.gnu.org; Wed, 23 Oct 2019 06:02:25 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNDTB-0001lK-B7; Wed, 23 Oct 2019 12:02:24 +0200 In-Reply-To: (Vivek Dasmohapatra's message of "Wed, 10 Jan 2018 13:58:43 +0000 (GMT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170044 Archived-At: Vivek Dasmohapatra writes: > The old code in lui.el used to (effectively) do this: > > (setq buffer-undo-list (mapcar a-lambda-here buffer-undo-list)) > > This seemed to cause some strings in the undo list structure to get > freed to early, then freed again later. > > The altered code uses the approach of setf'ing the relevant elements of > the undo-list, which doesn't trick the GC code into a premature free. > > Since there's a workaround it's not particularly urgent, but it seems > to me that there's a hole in the GC logic somewhere. If I understand correctly, the external lui package set buffer-undo-list to something invalid, and this led Emacs to segfault when gc-ing? Was there any further work done here, or a reproducible test case written? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no