From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 39190@debbugs.gnu.org, Felician Nemeth <felician.nemeth@gmail.com>
Subject: bug#39190: 28.0.50; two buffers with same buffer-file-name (diff-syntax-fontify-props)
Date: Wed, 25 Mar 2020 23:48:00 +0200 [thread overview]
Message-ID: <87ftdwgl7z.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvk138404k.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 25 Mar 2020 17:13:09 -0400")
>> is presented in diff context without the terminating
>> "End:" then opening such attachment patch raises the error:
>>
>> "Local variables list is not properly terminated"
>
> Really? AFAICT the code does:
>
> (unless (let ((case-fold-search t))
> (re-search-forward
> (concat prefix "[ \t]*End:[ \t]*" suffix)
> nil t))
> ;; This used to be an error, but really all it means is
> ;; that this may simply not be a local-variables section,
> ;; so just ignore it.
> (message "Local variables list is not properly terminated"))
>
> so it shouldn't signal an error but just emit a message.
Sorry, actually this is what is displayed in the echo area after I added
ignore-errors. But before adding ignore-errors, there was such backtrace:
Debugger entered--Lisp error: (error "Malformed local variable line: \"Local Variables:\"")
signal(error ("Malformed local variable line: \"Local Variables:\""))
error("Malformed local variable line: %S" "Local Variables:")
hack-local-variables(t)
set-auto-mode()
(let ((delay-mode-hooks t)) (set-auto-mode))
(progn (make-local-variable 'delay-mode-hooks) (let ((delay-mode-hooks t)) (set-auto-mode)))
diff-syntax-fontify-props(#("a/lisp/dired-aux.el" ...
diff-syntax-fontify-hunk(136 1334 t)
diff-syntax-fontify(136 1334)
diff--iterate-hunks(3750 #f(compiled-function (beg end) #<bytecode 0x877598e526a1ebd>))
diff--font-lock-syntax(3750)
font-lock-fontify-keywords-region(1 3750 nil)
font-lock-default-fontify-region(1 3750 nil)
font-lock-fontify-region(1 3750)
font-lock-ensure()
mm-display-inline-fontify(...
mm-display-patch-inline(...
mm-display-inline(...
gnus-mime-display-single(...
gnus-mime-display-part(...
gnus-mime-display-mixed(...
gnus-mime-display-part(...
gnus-display-mime()
gnus-article-prepare-display()
gnus-article-prepare(165466 nil)
gnus-summary-display-article(165466 nil)
gnus-summary-select-article(nil nil pseudo)
gnus-summary-scroll-up(1)
funcall-interactively(gnus-summary-scroll-up 1)
call-interactively(gnus-summary-scroll-up nil nil)
command-execute(gnus-summary-scroll-up)
>> Not sure if this is the right way to fix this, but it works:
>
> I think we should try and arrange for errors to really be "not normal",
> and then use `with-demoted-errors`, yes.
>
> But w.r.t file-local variables and diff-hunk, I think obeying "file-local
> variables" doesn't make much sense when we only have a hunk to go on
> since it's more common for the hunk not to include the actual file-local
> vars, so if we find something it's likely to be a false-positive.
I'll try to set enable-local-variables to nil in case of HUNK-ONLY.
prev parent reply other threads:[~2020-03-25 21:48 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 11:14 bug#39190: 28.0.50; two buffers with same buffer-file-name (diff-syntax-fontify-props) Felician Nemeth
2020-01-20 22:56 ` Juri Linkov
2020-01-20 23:34 ` Stefan Monnier
2020-01-24 0:13 ` Juri Linkov
2020-01-24 14:18 ` Stefan Monnier
2020-01-28 0:01 ` Juri Linkov
2020-01-28 1:30 ` Stefan Monnier
2020-01-28 3:32 ` Eli Zaretskii
2020-01-28 13:58 ` Stefan Monnier
2020-01-28 14:54 ` Dmitry Gutov
2020-01-28 22:53 ` Juri Linkov
2020-01-28 17:54 ` Eli Zaretskii
2020-01-28 20:12 ` Stefan Monnier
2020-01-28 20:23 ` Eli Zaretskii
2020-01-28 23:17 ` Stefan Monnier
2020-01-29 17:13 ` Eli Zaretskii
2020-01-29 21:33 ` Stefan Monnier
2020-01-30 14:17 ` Eli Zaretskii
2020-01-30 14:34 ` Stefan Monnier
2020-01-30 22:50 ` Juri Linkov
2020-01-30 23:09 ` Stefan Monnier
2020-01-30 23:31 ` Dmitry Gutov
2020-01-26 19:34 ` Felician Nemeth
2020-01-28 0:05 ` Juri Linkov
2020-01-28 17:18 ` Felician Nemeth
2020-01-29 23:07 ` Juri Linkov
2020-01-30 19:48 ` Felician Nemeth
2020-01-30 22:45 ` Juri Linkov
2020-02-02 9:42 ` Felician Nemeth
2020-02-02 13:50 ` Stefan Monnier
2020-02-02 23:41 ` Juri Linkov
2020-02-03 13:14 ` Dmitry Gutov
2020-02-03 22:44 ` Juri Linkov
2020-02-04 13:08 ` Dmitry Gutov
2020-02-03 22:45 ` Juri Linkov
2020-02-04 13:36 ` Stefan Monnier
2020-02-04 23:20 ` Juri Linkov
2020-02-05 22:39 ` Juri Linkov
2020-02-09 16:06 ` Felician Nemeth
2020-02-18 0:06 ` Juri Linkov
2020-02-18 13:33 ` Stefan Monnier
2020-02-18 22:53 ` Juri Linkov
2020-02-18 23:07 ` Stefan Monnier
2020-02-18 23:31 ` Stefan Monnier
2020-02-19 0:49 ` Juri Linkov
2020-02-19 13:20 ` Stefan Monnier
2020-02-20 0:58 ` Juri Linkov
2020-03-24 21:37 ` Juri Linkov
2020-03-24 22:29 ` Stefan Monnier
2020-03-25 20:39 ` Juri Linkov
2020-03-25 21:13 ` Stefan Monnier
2020-03-25 21:48 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftdwgl7z.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=39190@debbugs.gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).