From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 35353@debbugs.gnu.org
Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name
Date: Sat, 22 Aug 2020 16:41:18 +0200 [thread overview]
Message-ID: <87ft8elp4h.fsf@gnus.org> (raw)
In-Reply-To: <c3196792-c576-bb89-e55a-b77b4f4111e5@yandex.ru> (Dmitry Gutov's message of "Mon, 22 Apr 2019 13:52:17 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> The fix is not hard, though. Is the variable more targeted on other
> use cases? Or is it just obscure enough for us not to bother?
>
> The patch looks like this (to be accompanied with an appropriate renaming):
[...]
> - (define-key map [mouse-1] #'xref-goto-xref)
> - (define-key map [mouse-2] #'xref--mouse-2)
> + (define-key map [follow-link] 'mouse-face)
> + (define-key map [mouse-2] #'xref-goto-xref)
> + (define-key map [mouse-1] #'xref--mouse-2)
I think that this is basically what most modes that have clickable stuff
do, so I think it might be the right solution for xref, too (even if
xref doesn't have buttons per se).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-22 14:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-21 2:50 bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name Drew Adams
2019-04-21 13:27 ` Drew Adams
2019-04-22 9:24 ` Dmitry Gutov
2019-04-22 9:42 ` Eli Zaretskii
2019-04-22 9:48 ` Dmitry Gutov
2019-04-22 10:09 ` Eli Zaretskii
2019-04-22 10:18 ` Dmitry Gutov
2019-04-22 10:21 ` Eli Zaretskii
2019-04-22 10:52 ` Dmitry Gutov
2019-04-22 10:57 ` Dmitry Gutov
2019-04-22 11:42 ` Phil Sainty
2019-04-22 13:08 ` Drew Adams
2019-05-02 22:35 ` Dmitry Gutov
2019-05-02 23:22 ` Drew Adams
2019-05-02 23:31 ` Dmitry Gutov
2019-05-03 0:27 ` Drew Adams
2019-05-04 21:21 ` Richard Stallman
2019-05-04 22:25 ` Drew Adams
2019-05-05 22:50 ` Richard Stallman
2019-05-06 0:40 ` Drew Adams
2019-05-06 8:45 ` Dmitry Gutov
2019-05-06 13:29 ` Drew Adams
2019-05-02 22:48 ` Dmitry Gutov
2019-05-02 23:22 ` Drew Adams
2019-05-02 23:34 ` Dmitry Gutov
2019-05-03 0:27 ` Drew Adams
2019-04-22 11:07 ` Drew Adams
2019-04-22 11:18 ` Eli Zaretskii
2019-04-22 11:30 ` Dmitry Gutov
2019-04-22 11:34 ` Eli Zaretskii
2019-05-02 22:49 ` Dmitry Gutov
2019-05-03 6:38 ` Eli Zaretskii
2020-08-22 14:41 ` Lars Ingebrigtsen [this message]
2020-08-22 17:46 ` Drew Adams
[not found] ` <<83v9z6732b.fsf@gnu.org>
2019-04-22 11:07 ` Drew Adams
2019-04-22 11:20 ` Eli Zaretskii
[not found] ` <<<83v9z6732b.fsf@gnu.org>
[not found] ` <<376d5335-eb80-4272-8847-e764242a02b7@default>
[not found] ` <<83r29u70cy.fsf@gnu.org>
2019-04-22 12:23 ` Drew Adams
2019-04-22 13:05 ` Eli Zaretskii
[not found] ` <<<<83v9z6732b.fsf@gnu.org>
[not found] ` <<<376d5335-eb80-4272-8847-e764242a02b7@default>
[not found] ` <<<83r29u70cy.fsf@gnu.org>
[not found] ` <<c1e7f520-7dff-41e0-ba01-9828b87cb703@default>
[not found] ` <<83imv66vi2.fsf@gnu.org>
2019-04-22 13:23 ` Drew Adams
2019-04-22 13:33 ` Eli Zaretskii
[not found] ` <<83y34273mu.fsf@gnu.org>
2019-04-22 10:58 ` Drew Adams
2022-04-29 12:01 ` Lars Ingebrigtsen
2022-04-29 17:13 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft8elp4h.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=35353@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).