From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#42499: [PATCH] Add Bytecode Offset information to Backtrace Date: Sat, 17 Oct 2020 11:08:29 +0200 Message-ID: <87ft6dusmq.fsf@gnus.org> References: <87tuxxzucm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18456"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42499@debbugs.gnu.org To: Zach Shaftel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 17 11:09:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTiD9-0004gm-AP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Oct 2020 11:09:11 +0200 Original-Received: from localhost ([::1]:40498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTiD8-00028o-D1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Oct 2020 05:09:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTiD0-00026f-O0 for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 05:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTiD0-0004fc-E9 for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 05:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTiD0-0005Zw-7l for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 05:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 09:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42499-submit@debbugs.gnu.org id=B42499.160292572121412 (code B ref 42499); Sat, 17 Oct 2020 09:09:02 +0000 Original-Received: (at 42499) by debbugs.gnu.org; 17 Oct 2020 09:08:41 +0000 Original-Received: from localhost ([127.0.0.1]:33307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTiCe-0005ZH-OZ for submit@debbugs.gnu.org; Sat, 17 Oct 2020 05:08:40 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTiCd-0005Z4-FD for 42499@debbugs.gnu.org; Sat, 17 Oct 2020 05:08:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z493cokkFUVvnLW50M8XP9VSZlZpG92ObAPNjExuxYM=; b=erqQn/VnrVRSDcjrmYNBXj6biz NhHesMb1tdvXT6Mx+z61v6Ybe007cIycwSSzSeKLy6aKfUol9Jf5f99vCQVo56Avm4gKKqxiW8K5d xNviKf1Nzn/iPREacsV3fABuuV4gHRTAH5+Jd0xbYwZLPkbGxgEWptiguEdOhRDv5KTU=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTiCV-0001kf-6T; Sat, 17 Oct 2020 11:08:33 +0200 X-Now-Playing: Machinedrum's _Vapor City Citizenship Programme_: "SeeSea VIP" In-Reply-To: <87tuxxzucm.fsf@gmail.com> (Zach Shaftel's message of "Thu, 23 Jul 2020 19:29:48 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190782 Archived-At: Zach Shaftel writes: > This patch adds the offset in a bytecode function's execution where an > error occurs to the *Backtrace* buffer, like this: > > Debugger entered--Lisp error: (wrong-type-argument stringp t) > string-match(t t nil) > 13 test-condition-case() > load("/home/zach/.repos/bench-compare.el/test/test-debug...") > 78 byte-recompile-file("/home/zach/.repos/bench-compare.el/test/test-debug..." nil 0 t) > 35 emacs-lisp-byte-compile-and-load() > funcall-interactively(emacs-lisp-byte-compile-and-load) > call-interactively(emacs-lisp-byte-compile-and-load record nil) > 101 command-execute(emacs-lisp-byte-compile-and-load record) > > If you disassemble one of the annotated functions, you can find the > instruction where the error occured. Sounds useful, but probably somewhat less so since Emacs is moving to natively compiling Elisp in Emacs 28. Does anybody else have an opinion here? > My copyright assignment is still pending so I assume this can't be > merged until I hear back from copyright-clerk. This was in July, and I can't see your name in the copyright assingment file. Did the assignment process stall? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no