From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#45345: [elpa-archive] "make build/" should not pull unconditionally Date: Mon, 21 Dec 2020 11:47:02 +0100 Message-ID: <87ft3zbfmh.fsf@bernoul.li> References: <875z4wi5i6.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21030"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45345@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 21 11:48:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krIju-0005Lq-1w for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Dec 2020 11:48:30 +0100 Original-Received: from localhost ([::1]:48202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krIjs-000557-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Dec 2020 05:48:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krIjS-00054i-U7 for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 05:48:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34856) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krIjS-0007DQ-E3 for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 05:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1krIjS-0001Ct-8R for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 05:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Dec 2020 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45345 X-GNU-PR-Package: emacs Original-Received: via spool by 45345-submit@debbugs.gnu.org id=B45345.16085476264475 (code B ref 45345); Mon, 21 Dec 2020 10:48:02 +0000 Original-Received: (at 45345) by debbugs.gnu.org; 21 Dec 2020 10:47:06 +0000 Original-Received: from localhost ([127.0.0.1]:46402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krIiY-0001A6-0M for submit@debbugs.gnu.org; Mon, 21 Dec 2020 05:47:06 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]:50662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krIiW-00019s-9c for 45345@debbugs.gnu.org; Mon, 21 Dec 2020 05:47:05 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id DDEC0165CD; Mon, 21 Dec 2020 11:47:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1608547622; bh=KBXqcWqKur6euIpIYBhbxcse WRpa6HeMJ4KU1inmuVw=; b=ze447qvb4yOlbixYM+6de7uax/vl5Hn0+r6urutX IsdhYIv+bnd9DtdWmjXRhAQ4sb5sr99cobfjTIoYJCEYVwpbrFcDH7hTjUQT9FD7 K379SxSCh2xXA1xN2CN46KObfttAE/M5XfniD0OMCAfraX5IJ4mZNcFphNEWwh7g vLg= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id s5Ou6qqFxCKP; Mon, 21 Dec 2020 11:47:02 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id AB16A165C7; Mon, 21 Dec 2020 11:47:02 +0100 (CET) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196532 Archived-At: Stefan Monnier writes: >>> - Another advantage is that the new code makes it much easier to build >>> your own tarballs, for example to test them before pushing to code. >>> You can just do `make build/[PKGNAME]` and the resulting package will >>> be built in `archive/[PKGNAME]-[VERSION].tar. >> That almost worked. "make build/" (or `elpaa--make-one-package') >> calls `elpaa--external-package-sync', which pulls. That of course is not >> desirable when one wants to test some other revision of the package than >> what would end up being pulled. > > Could you give some detail about the situation in which doing `git pull` > was a problem for you? I was making some experimental changes. In this case the changes where to transient's internal tools responsible for updating version numbers in the manual. These tools are broken when used in a worktree of the elpa repository because they relay in git tags, which do not exist here. I did not want to push any of these very temporary experiments to the public transient repository, just so elpa-archive could pull them from there. IMO its irrelevant what experiments I was running. There will always be things people will want to try out before making them public. > I mean, obviously I could just move that call to > `elpaa--external-package-sync` elsewhere, but `elpaa--make-one-package' > is supposed to make packages from *commits* (it normally makes two > packages, one from the head of the branch and another from the last > commit that changed `Version:` line) so it "inherently" moves between > different commits. I dealt with that by creating a temporary dummy commit. I also bumped the Package-Version to some temporary fantasy number in that same commit. None of that I want to push to some public location just so I can test locally. Jonas