unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / Atom feed
* bug#45797: 28.0.50; [PATCH]: Simplify comint-read-input-ring
@ 2021-01-11 19:20 Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-01-12 12:29 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-01-11 19:20 UTC (permalink / raw)
  To: 45797

[-- Attachment #1: Type: text/plain, Size: 80 bytes --]

See attached.

-- 
Sent with https://mailfence.com
Secure and private email

[-- Attachment #2: File Attachment: 0001-comint-read-input-ring-Simplify-last-commit.patch --]
[-- Type: text/x-diff, Size: 922 bytes --]

From 7adf2a49d3b247f424b7a9c2fab24a82418bbb8e Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Mon, 11 Jan 2021 11:09:30 -0800
Subject: [PATCH] comint-read-input-ring: Simplify last commit

* lisp/comint.el (comint-read-input-ring): Simplify.

It is not necessary to use `goto-char' again since we have already
moved point to the desired location.
---
 lisp/comint.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/comint.el b/lisp/comint.el
index 3476fd146c..53153af7d2 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -1000,7 +1000,6 @@ comint-read-input-ring
                    (goto-char (match-end 0)))
                  (setq start (point))
                  (setq history (buffer-substring start end))
-                 (goto-char start)
                  (when (and (not (string-match history-ignore history))
 			    (or (null ignoredups)
 				(ring-empty-p ring)
-- 
2.29.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#45797: 28.0.50; [PATCH]: Simplify comint-read-input-ring
  2021-01-11 19:20 bug#45797: 28.0.50; [PATCH]: Simplify comint-read-input-ring Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-01-12 12:29 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2021-01-12 12:29 UTC (permalink / raw)
  To: Brian Leung; +Cc: 45797

Brian Leung <leungbk@mailfence.com> writes:

> See attached.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-12 12:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 19:20 bug#45797: 28.0.50; [PATCH]: Simplify comint-read-input-ring Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-12 12:29 ` Lars Ingebrigtsen

unofficial mirror of bug-gnu-emacs@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/emacs-bugs/0 emacs-bugs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 emacs-bugs emacs-bugs/ https://yhetil.org/emacs-bugs \
		bug-gnu-emacs@gnu.org
	public-inbox-index emacs-bugs

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.bugs
	nntp://news.gmane.io/gmane.emacs.bugs


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git