From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames. Date: Sat, 13 Feb 2021 20:23:20 +0200 Organization: LINKOV.NET Message-ID: <87ft1zsu75.fsf@mail.linkov.net> References: <871rdv4xog.fsf@gmail.com> <87a6sfu0fi.fsf@mail.linkov.net> <87v9b2ifrz.fsf@mail.linkov.net> <55ebad56-b440-198a-653e-1660040d5eae@gmx.at> <38b988fd-2ad6-a596-23a0-1d765249f718@gmx.at> <87tuqjydku.fsf@mail.linkov.net> <871rdlr4vc.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2473"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 46299@debbugs.gnu.org To: Bastian Beranek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 13 19:34:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAzkQ-0000Vm-Bb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 19:34:26 +0100 Original-Received: from localhost ([::1]:47846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAzkP-0006LG-Cr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 13:34:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAzk3-0006Jx-E3 for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 13:34:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAzk2-0001B0-49 for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 13:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lAzk2-0001lv-0T for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 13:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Feb 2021 18:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46299 X-GNU-PR-Package: emacs Original-Received: via spool by 46299-submit@debbugs.gnu.org id=B46299.16132411916737 (code B ref 46299); Sat, 13 Feb 2021 18:34:01 +0000 Original-Received: (at 46299) by debbugs.gnu.org; 13 Feb 2021 18:33:11 +0000 Original-Received: from localhost ([127.0.0.1]:35039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAzjD-0001kb-8i for submit@debbugs.gnu.org; Sat, 13 Feb 2021 13:33:11 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:53167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAzjB-0001k5-2P for 46299@debbugs.gnu.org; Sat, 13 Feb 2021 13:33:09 -0500 Original-Received: from mail.gandi.net (m91-129-108-204.cust.tele2.ee [91.129.108.204]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 343E1240005; Sat, 13 Feb 2021 18:33:00 +0000 (UTC) In-Reply-To: (Bastian Beranek's message of "Fri, 12 Feb 2021 20:23:26 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199949 Archived-At: Hey Bastian, Thank you for working on this patch. Please prepare the ChangeLog commit message, so your patch could be pushed to master. Then it would be easier to reason about further changes and base them on the pushed version. > @@ -89,8 +89,9 @@ tab-bar-select-tab-modifiers > :set (lambda (sym val) > (set-default sym val) > ;; Reenable the tab-bar with new keybindings > - (tab-bar-mode -1) > - (tab-bar-mode 1)) > + (when tab-bar-mode > + (tab-bar-mode -1) > + (tab-bar-mode 1))) > :group 'tab-bar > :version "27.1") > > This seems to fix the issue. I can't say I fully understand why > though. It must have something to do with running > tab-bar--update-tab-bar-lines in early initialization? We could also > wrap the call to tab-bar--update-tab-bar-lines. The problem is that currently the function tab-bar-mode contains: (if tab-bar-mode (tab-bar--define-keys) ;; Unset only keys bound by tab-bar (when (eq (global-key-binding [(control tab)]) 'tab-next) (global-unset-key [(control tab)])) ... If the global-unset-key part would be refactored into a separate function, then tab-bar-select-tab-modifiers could call two functions sequentially: a new function that undefines old keys, then the existing separate function tab-bar--define-keys that will define keys with customized modifier.