unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: haj@posteo.de (Harald Jörg)
Cc: 46574@debbugs.gnu.org
Subject: bug#46574: cperl-mode: Improve detection of entries for imenu [PATCH]
Date: Wed, 17 Feb 2021 00:56:56 +0100	[thread overview]
Message-ID: <87ft1vpnw7.fsf@gnus.org> (raw)
In-Reply-To: <87tuqbefrb.fsf@hajtower> ("Harald Jörg"'s message of "Wed, 17 Feb 2021 00:48:08 +0100")

haj@posteo.de (Harald Jörg) writes:

> I've reviewed Stefan's changes now.  There is definitely no conflict and
> the patch can be applied regardless of the offset.  The offset mainly
> came with 24a98755 (Feb 13), where Stefan eliminated a length of
> obsolete documentation.

Thanks for checking; I've now applied your patch to Emacs 28.

> BTW: Stefan's cleanup work is great here.

Yup.

> I've always wanted to start working on this but I am not confident
> enough.  I don't know enough about the histories of (X)Emacs and
> CPerl-mode.

I'm a bit vague about the history of the mode, too, but it's OK to rip
out all XEmacs compat code (and compat code with Emacs < 26.1, I think).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2021-02-16 23:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 22:54 bug#46574: cperl-mode: Improve detection of entries for imenu [PATCH] Harald Jörg
2021-02-16 23:03 ` Lars Ingebrigtsen
2021-02-16 23:48   ` Harald Jörg
2021-02-16 23:56     ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft1vpnw7.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=46574@debbugs.gnu.org \
    --cc=haj@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).